From owner-svn-ports-all@FreeBSD.ORG Fri Mar 8 13:30:02 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 8134DEE3; Fri, 8 Mar 2013 13:30:02 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) by mx1.freebsd.org (Postfix) with ESMTP id 0AF90136; Fri, 8 Mar 2013 13:30:01 +0000 (UTC) Received: from mercury.ph.man.ac.uk [130.88.75.175:62672] (HELO/EHLO mercury.ph.man.ac.uk, authenticated with LOGIN) by mail.issp.ac.ru with ESMTP/inet id r28DU0G2042178 (using TLSv1/SSLv3, with cipher DHE-RSA-AES256-SHA (256 bits), verified NO) Fri, 8 Mar 2013 17:30:01 +0400 (MSK) From: Max Brazhnikov To: Nicola Vitale Subject: Re: Re: svn commit: r313554 - in head/audio: . tomahawk tomahawk/files Date: Fri, 08 Mar 2013 13:31:01 +0000 Message-ID: <4799790.NVjaq9lW0x@mercury.ph.man.ac.uk> User-Agent: KMail/4.9.5 (FreeBSD/9.1-STABLE; KDE/4.10.1; amd64; ; ) In-Reply-To: References: <201303062255.r26Mtxdc099852@svn.freebsd.org> <2755783.8nzRuugVsi@mercury.ph.man.ac.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="ISO-8859-1" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2013 13:30:02 -0000 On Thu, 07 Mar 2013 15:16:25 +0100 Nicola Vitale wrote: > Hi, > > > [2013/3/7 Max Brazhnikov ] > >> +RUN_DEPENDS= phonon-vlc>=0.6.1:${PORTSDIR}/multimedia/phonon-vlc \ > >> + phonon-gstreamer>=4.6.3:${PORTSDIR}/multimedia/phonon- > > gstreamer \ > > Please don't force dependence on phonon backends until upstream strictly > > recommend particular one. > > I added both because in the CMakeLists.txt there is this line: > > if(PHONON_FOUND) > message(STATUS "Phonon found; ensure that phonon-vlc is at least 0.4") > endif() looks like they prefer vlc, but this is far from strict requirement :) You can use options for this, e.g. OPTIONS_GROUP_PHONON= GSTREAMER VLC XINE OPTIONS_DEFAULT= GSTREAMER .if ${PORT_OPTIONS:MGSTREAMER} RUN_DEPENDS+= phonon-gstreamer>=4.6.3:${PORTSDIR}/multimedia/phonon-gstreamer .endif and similar for vlc and xine backends Max