From owner-svn-src-all@freebsd.org Fri Jan 26 07:02:38 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59DC8EC5D56 for ; Fri, 26 Jan 2018 07:02:38 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-lf0-x231.google.com (mail-lf0-x231.google.com [IPv6:2a00:1450:4010:c07::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BFB7C86A57 for ; Fri, 26 Jan 2018 07:02:37 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-lf0-x231.google.com with SMTP id 63so6608978lfv.4 for ; Thu, 25 Jan 2018 23:02:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pdQJY1tNpkZcon4wO9T7iThiAK0dSB46XrWohdcKO5w=; b=lkR18B4TCn2/wJUUlOsyEEV8hLjE8qU4SqmH2nzAyY4B4B1P0at4x27+eQljRjvAAa N1NPDQRKORjh86eVAZfwCdsii9iDkOc90zSSuAzkEgr35J6K2jRVrxTTsdcIfCwP6juj DNB+Kg0Oh0VpLxL4pGiRCJXgXgro38HxuD1Fj8aSRfnw85WkOhq2NK7ztuHT7ncF+Jhw n1m5rK7toBzZcezLJEruHPO6ZrP+Jao/la5i6fvGLVylFXMg5NTlEtGjAk6DRMxo3b5l cTTgvIjJ3DouSHaV5G+VoLYJVrYURT/Q5pwKwwOiFOeN2hcvWXe+CEv3ZsEnjJptUROe E2dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pdQJY1tNpkZcon4wO9T7iThiAK0dSB46XrWohdcKO5w=; b=Ii7bMUCi8gFnthcJVr921j/6wpX36ZAqxnO1ZF8pqM78sx19VWgjzJvggnP2SABl3N TF20uys4vdCep9aU+sylxH8ZcI3hOg7JVkg3ttSIr/DO2NVq7VaWiIuaOVliaerC/xzf rU4emaLEefJH7IdpNaQGXMZe2n1I7nwFQ6O0UvqdVPhtM3av16xkCSPHfPS8pVm2ySSE bN3CWxjSStnqvF1ZQ9GcKn3sGgZFlGpl/taAeeFFSYX4szjd9xogemh0YoUQY0OEz64E WnxyTK1YiVMXWZ93k97NODl5oh8VIRKeYGVCZoWR/cRMrmCk3J6Hp0cbOmz5KDRJ4pll 6aiQ== X-Gm-Message-State: AKwxyteJecV0Rxrm1/zcl8u/GiOemK5OSslMHEynshYmkmojIGEioJ8A TCp7DCGMY7YRKkmOIB6MMC9kY8zYT8Qrihw2d9g9FQ== X-Google-Smtp-Source: AH8x226VHbQEUzWRqNulMh75RmR0RYcuPsJOXWuBs6TJc4H54/gRuutmUeOj4on+j12pCb7bZ0UHkWq62gMfarsoJ18= X-Received: by 10.46.115.22 with SMTP id o22mr7873793ljc.89.1516950155022; Thu, 25 Jan 2018 23:02:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.216.206 with HTTP; Thu, 25 Jan 2018 23:02:04 -0800 (PST) In-Reply-To: References: <201801260440.w0Q4efhg008105@repo.freebsd.org> From: Ed Schouten Date: Fri, 26 Jan 2018 08:02:04 +0100 Message-ID: Subject: Re: svn commit: r328430 - head/sbin/devd To: Warner Losh Cc: Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 07:02:38 -0000 2018-01-26 5:52 GMT+01:00 Warner Losh : > Everything needs a virtual destructor... Please back that part of this > out... If you're concerned about inheritance, what about adding the 'final' keyword to the class? http://en.cppreference.com/w/cpp/language/final Eitan: static void usage(void) __dead2; This should be spelled: [[noreturn]] static void usage(); -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands