Date: Thu, 24 May 2018 16:37:52 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470615 - head Message-ID: <20180524143752.7vpfnzfxwkczi6h3@ogg.in.absolight.net> In-Reply-To: <20180524145450.3345318f@kalimero.tijl.coosemans.org> References: <201805221358.w4MDwYtl021212@repo.freebsd.org> <20180522160246.239217d9@kalimero.tijl.coosemans.org> <20180524124550.wxsfet7qts3zevq7@ogg.in.absolight.net> <20180524145450.3345318f@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--rlku36rf6qb2pgqn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 24, 2018 at 02:54:50PM +0200, Tijl Coosemans wrote: > On Thu, 24 May 2018 14:45:50 +0200 Mathieu Arnold <mat@FreeBSD.org> wrote: > > On Tue, May 22, 2018 at 04:02:46PM +0200, Tijl Coosemans wrote: > >> On Tue, 22 May 2018 13:58:34 +0000 (UTC) Mathieu Arnold <mat@FreeBSD.o= rg> wrote: =20 > >>> Author: mat > >>> Date: Tue May 22 13:58:33 2018 > >>> New Revision: 470615 > >>> URL: https://svnweb.freebsd.org/changeset/ports/470615 > >>>=20 > >>> Log: > >>> Don't tell people to use @${FLAVOR} in that case, it's bad practice. > >>> =20 > >>> Sponsored by: Absolight > >>>=20 > >>> Modified: > >>> head/CHANGES > >>>=20 > >>> Modified: head/CHANGES > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >>> --- head/CHANGES Tue May 22 13:58:03 2018 (r470614) > >>> +++ head/CHANGES Tue May 22 13:58:33 2018 (r470615) > >>> @@ -152,8 +152,7 @@ AUTHOR: mat@FreeBSD.org > >>> =20 > >>> In all the ports with Python dependencies, the *_DEPENDS entries M= UST end > >>> with the flavor so that the framework knows which to build/use. T= his is done > >>> - by appending '@${PY_FLAVOR}' after the origin (or @${FLAVOR} if in= a Python > >>> - module with Python flavors, as the content will be the same). For= example: > >>> + by appending '@${PY_FLAVOR}' after the origin. For example: > >>> =20 > >>> RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FL= AVOR} =20 > >>=20 > >> There are still some dependencies under Mk/ without @${PY_FLAVOR}. =20 > > > > I cannot find any, can you be less vague? (or better, just fix them.) > >=20 >=20 > Some lines that look suspicious: >=20 All of those only work with Python 2.7, they all depend on a file though, so they are more or less flavor independant, and will work if the default is not 2.7. > bsd.wx.mk:_WX_PORT_python_2.8=3D x11-toolkits/py-wxPython28 > bsd.wx.mk:_WX_PORT_python_3.0=3D x11-toolkits/py-wxPython30 > Uses/gnome.mk:pygobject_BUILD_DEPENDS=3D pygobject-codegen-2.0:devel/py-g= object > Uses/gnome.mk:pygobject_RUN_DEPENDS=3D pygobject-codegen-2.0:devel/py-go= bject > Uses/gnome.mk:pygtk2_BUILD_DEPENDS=3D ${LOCALBASE}/libdata/pkgconfig/pygt= k-2.0.pc:x11-toolkits/py-gtk2 > Uses/gnome.mk:pygtk2_RUN_DEPENDS=3D ${LOCALBASE}/libdata/pkgconfig/pygtk-= 2.0.pc:x11-toolkits/py-gtk2 > Uses/gnome.mk:pygnome2_BUILD_DEPENDS=3D ${LOCALBASE}/libdata/pkgconfig/gn= ome-python-2.0.pc:x11-toolkits/py-gnome2 > Uses/gnome.mk:pygnome2_RUN_DEPENDS=3D ${LOCALBASE}/libdata/pkgconfig/gnom= e-python-2.0.pc:x11-toolkits/py-gnome2 > Uses/gnome.mk:pygtksourceview_BUILD_DEPENDS=3D ${LOCALBASE}/libdata/pkgco= nfig/pygtksourceview-2.0.pc:x11-toolkits/py-gtksourceview > Uses/gnome.mk:pygtksourceview_RUN_DEPENDS=3D ${LOCALBASE}/libdata/pkgconf= ig/pygtksourceview-2.0.pc:x11-toolkits/py-gtksourceview > Uses/kde.mk:pykde4_PORT=3D devel/py-pykde4-kde4 > Uses/kde.mk:pykdeuic4_PORT=3D devel/py-pykdeuic4-kde4 =20 This one is the only one which is a package dependency and will probably fail if the default is not 2.7: > bsd.gstreamer.mk:python_DEPENDS=3D multimedia/py-gstreamer --=20 Mathieu Arnold --rlku36rf6qb2pgqn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJbBs5AXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85ICgEP/2VPwBOMmWGYkR+qeWlxUXhH Y7dXElv4ZySaAvflzucLvsAKv4Wt6jMndp0nJusSlMbXq3qavFEQv6FKpKPMUFg4 y/ZlfYL9vAwUN4Mb1xiDqKwdtstLOSPFqkBU4ihklCjHLDy4poTtA1FJStPGMwOW 8YtBT4V+/Hhl/dIW8L6WiTHEIUHMr32eykRAgULKFpx7mT2kpF37jYHd+G9j6gVS 8Ud1lt8cslt3y3rx0ojLXY7ZXORgY4hVNBl6DutOtxQ7KYPgux6A6LXYZWLRc5Fb CiDqR6qpPuhCXQ7H1FNWuIOMprh1X404ULfuTrO90Vx78nlyg6Md6AXcOS7pQrXO PbAhf0AThS8HKeEwxHPg/JXaD33DPLzJLrXBeX8db387lmV9CppRG2Nol5WJm5sg 6zbAMXrbcNWCDuQZyFqiyWoQlLleLYt7Jiz330PpTc8YMBiqkKQpxVSf9Aiocyde Ai68oW5RU9rH9mgotAIKguZxpBB/D+ovboeDfnyxtcApq7HNxf+1AVoEzMha84Ba oQmlWlH3+TQP+xP6UOGo0Ej7rCecnNTzwfazE9Bq9RYzDNXemMOWBhH9xVbXsVCf G1vhFlqQPdtKUeAEprJUDoEXQkSvXezARaqLWVxzvpSKJdh/lQVyuar/1QuAIyTG WDXqrvY09VgoTAHwrkEn =uz4W -----END PGP SIGNATURE----- --rlku36rf6qb2pgqn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180524143752.7vpfnzfxwkczi6h3>