From owner-svn-ports-head@FreeBSD.ORG Sat Oct 6 22:34:35 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 52210106566B for ; Sat, 6 Oct 2012 22:34:35 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id CDC178FC0C for ; Sat, 6 Oct 2012 22:34:34 +0000 (UTC) Received: by mail-wg0-f42.google.com with SMTP id fm10so1128324wgb.1 for ; Sat, 06 Oct 2012 15:34:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=SHFpOwXQpyPrI/9of6vjWf+txWHruV2U5tRhyn2buRM=; b=cphB/EzG9iVSwwq+GsIQxikv7kgvYmI9exVR4Fwb/A+g7+6X437YX8pGExy+qP0p09 kkO2E2SwDyUG1yPjtOauTkYoiR8RoF2kcMsz2F4v2+hjym66dzRoFZ3ocq6prx7XtgQe 1BnhCb5DF/8w8mC7DgmW8HLz3+vJHxRfz1EyZDr+TtHguA/5u5NHrk+/TDn9wValk6Yc /pHJrQ/WBcZFd6P34eV0jK0v+8uvtUYpKNuOv6kO9/jFIpKywApYloTXRMABSq+EGAMh 4fLTrhVu5zQun37kB7v6CoQNLK7sd1+i42nIxMgxf2yl+g+DOfS151XyXOI9Qu+M+JBe 9WEg== MIME-Version: 1.0 Received: by 10.180.87.42 with SMTP id u10mr11410912wiz.0.1349562867934; Sat, 06 Oct 2012 15:34:27 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.194.81.136 with HTTP; Sat, 6 Oct 2012 15:34:27 -0700 (PDT) In-Reply-To: <5070B0F0.6080404@FreeBSD.org> References: <201210060537.q965bUpk005984@svn.freebsd.org> <5070A09B.1090404@FreeBSD.org> <5070B0F0.6080404@FreeBSD.org> Date: Sat, 6 Oct 2012 15:34:27 -0700 X-Google-Sender-Auth: BhFv2Tlj2hl-gN2I9QjADE5Mw2s Message-ID: From: Jason Helfman To: Doug Barton X-Gm-Message-State: ALoCoQntROLwk8oGkc3HbkZn5kLNu5uIXlJ3FqqoHYYdYpzv3zMAfXefGvMtWGT+XXYROHiF8eep Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, nemysis@gmx.ch, ports-committers@freebsd.org Subject: Re: svn commit: r305338 - in head/games/pycadia: . files X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2012 22:34:35 -0000 On Sat, Oct 6, 2012 at 3:30 PM, Doug Barton wrote: > On 10/06/2012 15:25, Jason Helfman wrote: > > On Sat, Oct 6, 2012 at 2:20 PM, Doug Barton > > wrote: > > > > On 10/05/2012 22:37, Jason Helfman wrote: > > > Added: head/games/pycadia/files/pycadia.sh.in < > http://pycadia.sh.in> > > > > > > ============================================================================== > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > > +++ head/games/pycadia/files/pycadia.sh.in > > Sat Oct 6 05:37:29 2012 (r305338) > > > @@ -0,0 +1,6 @@ > > > +#!/bin/sh > > > +# > > > +# $FreeBSD$ > > > + > > > +cd "%%DATADIR%%" > > > +./pycadia.py > > > > Unless there is some reason to cd into that directory, you'd be > better > > off with just: %%DATADIR%%/pycadia.py > > > > And in any case, shouldn't you be using exec here? > > > > > > I can check with the maintainer, but it does need to be run from the > > DATADIR specifically. > > Ok, that's not a problem. A comment to that effect would probably be > useful for future reference. > > > What would exec provide that isn't currently fulfilled? > > Eliminating the shell. > > Fair enough. I can discuss with maintainer, as he has many ports that do this. I would suggest using %%PYTHON_CMD%% in favor of exec. Do you see an issue with that? -jgh