From owner-svn-ports-all@freebsd.org Sun Oct 21 14:02:37 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DAC7FF2F36; Sun, 21 Oct 2018 14:02:37 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C7A868EE4F; Sun, 21 Oct 2018 14:02:36 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A89C16865; Sun, 21 Oct 2018 14:02:36 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w9LE2ajZ054916; Sun, 21 Oct 2018 14:02:36 GMT (envelope-from tobik@FreeBSD.org) Received: (from tobik@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w9LE2ar7054915; Sun, 21 Oct 2018 14:02:36 GMT (envelope-from tobik@FreeBSD.org) Message-Id: <201810211402.w9LE2ar7054915@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: tobik set sender to tobik@FreeBSD.org using -f From: Tobias Kortkamp Date: Sun, 21 Oct 2018 14:02:36 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org Subject: svn commit: r482675 - branches/2018Q4/devel/kore/files X-SVN-Group: ports-branches X-SVN-Commit-Author: tobik X-SVN-Commit-Paths: branches/2018Q4/devel/kore/files X-SVN-Commit-Revision: 482675 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2018 14:02:37 -0000 Author: tobik Date: Sun Oct 21 14:02:36 2018 New Revision: 482675 URL: https://svnweb.freebsd.org/changeset/ports/482675 Log: MFH: r481959 devel/kore: Add missing KORE_NO_TLS guards This fixes the build with OpenSSL 1.1.1 when TLS=off. PR: 231931 Obtained from: upstream Approved by: ports-secteam blanket Modified: branches/2018Q4/devel/kore/files/patch-src_domain.c Directory Properties: branches/2018Q4/ (props changed) Modified: branches/2018Q4/devel/kore/files/patch-src_domain.c ============================================================================== --- branches/2018Q4/devel/kore/files/patch-src_domain.c Sun Oct 21 13:34:20 2018 (r482674) +++ branches/2018Q4/devel/kore/files/patch-src_domain.c Sun Oct 21 14:02:36 2018 (r482675) @@ -1,8 +1,51 @@ -Remove when FreeBSD 10.4 is EOL. +From f87624a459342de33ff58619901da96749fad057 Mon Sep 17 00:00:00 2001 +From: Joris Vink +Date: Mon, 1 Oct 2018 10:36:33 +0200 +Subject: [PATCH] Add missing KORE_NO_TLS guards. ---- src/domain.c.orig 2018-07-19 08:34:48 UTC +Fixes NOTLS=1 builds on openssl 1.1.1 +--- + src/domain.c | 4 ++++ + 1 file changed, 4 insertions(+) + +With some additional changes to fix build with OpenSSL 1.0.1u on +FreeBSD 10.4. + +--- src/domain.c.orig 2018-07-18 14:25:49 UTC +++ src/domain.c -@@ -774,7 +774,7 @@ domain_load_certificate_chain(SSL_CTX *ctx, const void +@@ -125,6 +125,7 @@ kore_domain_init(void) + { + TAILQ_INIT(&domains); + ++#if !defined(KORE_NO_TLS) + #if !defined(LIBRESSL_VERSION_TEXT) && OPENSSL_VERSION_NUMBER >= 0x10100000L + if (keymgr_rsa_meth == NULL) { + if ((keymgr_rsa_meth = RSA_meth_new("kore RSA keymgr method", +@@ -143,6 +144,7 @@ kore_domain_init(void) + + EC_KEY_METHOD_set_sign(keymgr_ec_meth, NULL, NULL, keymgr_ecdsa_sign); + #endif ++#endif + } + + void +@@ -155,6 +157,7 @@ kore_domain_cleanup(void) + kore_domain_free(dom); + } + ++#if !defined(KORE_NO_TLS) + #if !defined(LIBRESSL_VERSION_TEXT) && OPENSSL_VERSION_NUMBER >= 0x10100000L + if (keymgr_rsa_meth != NULL) { + RSA_meth_free(keymgr_rsa_meth); +@@ -166,6 +169,7 @@ kore_domain_cleanup(void) + keymgr_ec_meth = NULL; + } + #endif ++#endif + } + + int +@@ -774,7 +778,7 @@ domain_load_certificate_chain(SSL_CTX *ctx, const void if (SSL_CTX_use_certificate(ctx, x) == 0) fatal("SSL_CTX_use_certificate: %s", ssl_errno_s); @@ -11,7 +54,7 @@ Remove when FreeBSD 10.4 is EOL. sk_X509_pop_free(ctx->extra_certs, X509_free); ctx->extra_certs = NULL; #else -@@ -784,7 +784,7 @@ domain_load_certificate_chain(SSL_CTX *ctx, const void +@@ -784,7 +788,7 @@ domain_load_certificate_chain(SSL_CTX *ctx, const void ERR_clear_error(); while ((ca = PEM_read_bio_X509(in, NULL, NULL, NULL)) != NULL) { /* ca its reference count won't be increased. */