From owner-svn-src-all@freebsd.org Wed Oct 7 18:09:40 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D44D49D011F; Wed, 7 Oct 2015 18:09:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id BC9B6F3F; Wed, 7 Oct 2015 18:09:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id B629416D5; Wed, 7 Oct 2015 18:09:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 5D81915967; Wed, 7 Oct 2015 18:09:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id YNJWFs0E2jYJ; Wed, 7 Oct 2015 18:09:38 +0000 (UTC) Subject: Re: svn commit: r288966 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com ED18D15960 To: "Simon J. Gerraty" References: <201510070032.t970WYvU099368@repo.freebsd.org> <56146B4E.5040401@FreeBSD.org> <24053.1444240925@chaos> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <56155FE0.7020809@FreeBSD.org> Date: Wed, 7 Oct 2015 11:09:36 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <24053.1444240925@chaos> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tuqMh49h3Uw1S5gekSqFk9vJkWw7u80oh" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 18:09:41 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tuqMh49h3Uw1S5gekSqFk9vJkWw7u80oh Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/7/2015 11:02 AM, Simon J. Gerraty wrote: > Bryan Drewery wrote: >>> +.for h in ${SRCS:M*.h} >> >> I think we can use DPSRCS as well for this. >=20 > Not sure. > usr.bin/truss/Makefile didn't use that. > I only see it set in bsd.dep.mk - which we don't use in meta mode. >=20 I'm less thinking about the usage in bsd.dep.mk and more these that manually set it: gnu/lib/libreadline/readline/Makefile:DPSRCS+=3D ${INSTALLED_HEADERS} lib/libc/tests/rpc/Makefile:DPSRCS+=3D h_testbits.h sbin/ipf/ipf/Makefile:DPSRCS+=3D ${GENHDRS} sbin/ipf/ipftest/Makefile:DPSRCS+=3D ${GENHDRS} sbin/ipf/ipmon/Makefile:DPSRCS+=3D ${GENHDRS} sbin/ipf/ipnat/Makefile:DPSRCS+=3D ${GENHDRS} sbin/ipf/ippool/Makefile:DPSRCS+=3D ${GENHDRS} sys/modules/linux/Makefile:DPSRCS=3D linux${SFX}_genassym.c sys/modules/linux64/Makefile:DPSRCS=3D linux_genassym.c sys/modules/vmm/Makefile:DPSRCS=3D vmx_genassym.c svm_genassym.c usr.bin/kdump/Makefile:DPSRCS=3D kdump_subr.h usr.bin/netstat/Makefile:DPSRCS=3D nl_defs.h usr.bin/svn/svn/Makefile:DPSRCS+=3D freebsd-organization.h I ran into at least one case, I think usr.bin/netstat, where the file in DPSRCS was missing and Makefile.depend had to learn how to build it before it would work. I can test more to see if adding it has any effect. --=20 Regards, Bryan Drewery --tuqMh49h3Uw1S5gekSqFk9vJkWw7u80oh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWFV/gAAoJEDXXcbtuRpfPIa4IAKM8fk5RLmDsCSl2PAwdBTPf ejHx63qh4OckWRB+gItp6KRqpOyAZZasKL3Vn1MZgBrNcDHgXEyLWVSQShlUjLnK 6r/gNQcRZIOJWYTOuaS1NbrHMJ1/4lNh3jyRnMyRh303gpGSW0tFo8fwBkd16SKs ikzaQu5/D1fFBLMKbOVUwub30isPxc7tDY1EvGUeMsVm+R/4uU/qj29hiP/sPnzN qTC/rGTM3erokWLEuRb7cOoczGW3Qy4oK2Z5I84Jkp5YJPoitWmAjX7sukUbK5FC iiq3/7QW0CBHrjgS5O0hfdBTftB4XxhdPjOMKLAd4hpr5FEzyNJKXvLxZP851EA= =rLjZ -----END PGP SIGNATURE----- --tuqMh49h3Uw1S5gekSqFk9vJkWw7u80oh--