From owner-freebsd-fs@FreeBSD.ORG  Mon Aug 21 14:09:34 2006
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
X-Original-To: freebsd-fs@freebsd.org
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CD8EB16A4DE;
	Mon, 21 Aug 2006 14:09:34 +0000 (UTC)
	(envelope-from Tor.Egge@cvsup.no.freebsd.org)
Received: from pil.idi.ntnu.no (pil.idi.ntnu.no [129.241.107.93])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0BC1D43D70;
	Mon, 21 Aug 2006 14:09:26 +0000 (GMT)
	(envelope-from Tor.Egge@cvsup.no.freebsd.org)
Received: from cvsup.no.freebsd.org (c2h5oh.idi.ntnu.no [129.241.103.69])
	by pil.idi.ntnu.no (8.13.6/8.13.1) with ESMTP id k7LE9LBw020785
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Mon, 21 Aug 2006 16:09:22 +0200 (MEST)
Received: from localhost (localhost [127.0.0.1])
	by cvsup.no.freebsd.org (8.13.4/8.13.4) with ESMTP id k7LE9Lmb042771;
	Mon, 21 Aug 2006 14:09:21 GMT
	(envelope-from Tor.Egge@cvsup.no.freebsd.org)
Date: Mon, 21 Aug 2006 14:09:20 +0000 (UTC)
Message-Id: <20060821.140920.85376544.Tor.Egge@cvsup.no.freebsd.org>
To: anderson@centtech.com
From: Tor Egge <Tor.Egge@cvsup.no.freebsd.org>
In-Reply-To: <44E9B722.2040407@centtech.com>
References: <20060818.202001.74745664.Tor.Egge@cvsup.no.freebsd.org>
	<20060821.132151.41668008.Tor.Egge@cvsup.no.freebsd.org>
	<44E9B722.2040407@centtech.com>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Virus-Scanned-By: mimedefang.idi.ntnu.no, using CLAMD
X-SMTP-From: Sender=<Tor.Egge@cvsup.no.freebsd.org>,
	Relay/Client=c2h5oh.idi.ntnu.no [129.241.103.69],
	EHLO=cvsup.no.freebsd.org
X-Scanned-By: MIMEDefang 2.48 on 129.241.107.38
X-Scanned-By: mimedefang.idi.ntnu.no,
	using MIMEDefang 2.48 with local filter 16.42-idi
X-Filter-Time: 0 seconds
Cc: freebsd-fs@freebsd.org, tegge@freebsd.org
Subject: Re: Deadlock between nfsd and snapshots.
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Aug 2006 14:09:34 -0000

> Does this mean that setting the noatime flag on mount would dodge this?

It might solve the deadlock issue when creating snapshots.  Note that snapshots
might fail to make copies of the original content when file system metadata
changes on some systems (cf. PR kern/100365).

Setting the noatime flag does not prevent ufs_itimes() from changing the inode
flags without proper locking.  IN_CHANGE might be set on the inode after a
chmod() system call, a following fstat() system call can then trigger a call to
ufs_itimes().

- Tor Egge