From owner-freebsd-ipfw@FreeBSD.ORG Tue Apr 5 10:05:15 2005 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CEE5116A4CE; Tue, 5 Apr 2005 10:05:15 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE97B43D2F; Tue, 5 Apr 2005 10:05:14 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id j35A5CiB024867 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 5 Apr 2005 14:05:13 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.1/8.12.8) with ESMTP id j35A5B7a042162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 5 Apr 2005 14:05:12 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.1/8.13.1/Submit) id j35A5Br1042161; Tue, 5 Apr 2005 14:05:11 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 5 Apr 2005 14:05:11 +0400 From: Gleb Smirnoff To: luigi@FreeBSD.org, andre@FreeBSD.org, maxim@FreeBSD.org Message-ID: <20050405100511.GA41910@cell.sick.ru> References: <200504050131.j351VGw0025916@atex.rinet.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200504050131.j351VGw0025916@atex.rinet.ru> User-Agent: Mutt/1.5.6i X-Virus-Scanned: ClamAV version devel-20050125, clamav-milter version 0.80ff on relay.bestcom.ru X-Virus-Status: Clean cc: freebsd-ipfw@FreeBSD.org cc: Oleg Bulyzhin cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: kern/79546: dummynet & ipfw tee: kernel may hang (endless loop) X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2005 10:05:16 -0000 Collegues, Can you please look at this PR? I see the suggested fix acceptable for now and for ABI frozen RELENG_5 branch. Speaking of HEAD and future RELENG_6, I'd prefer to move the code that searches for PACKET_TAG_DIVERT up to ip_fw_pfil.c, like we do it for dummynet and ng_ipfw returned packets. What do you think? http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/79546 -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE