Date: Tue, 11 May 2004 18:35:38 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: arch@freebsd.org Subject: Re: New ACPI blacklist format Message-ID: <20040511.183538.13771005.imp@bsdimp.com> In-Reply-To: <20040511151428.P77557@root.org> References: <20040507231846.F52653@root.org> <20040508164334.GA3217@dhcp01.pn.xcllnt.net> <20040511151428.P77557@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20040511151428.P77557@root.org> Nate Lawson <nate@root.org> writes: : On Sat, 8 May 2004, Marcel Moolenaar wrote: : > On Fri, May 07, 2004 at 11:28:15PM -0700, Nate Lawson wrote: : > : > *snip* : > : > > static struct acpi_table_desc Abit_BP6[] = { : > > { "FACP", "AWARD", "AWRDACPI", "<=", "30302e31", "", "", "" }, : > > }; : > > static struct acpi_table_desc AMI_INT[] = { /* 01/18/00 */ : > > { "FACP", "AWARD", "", "<=", "10", "", "", "" }, : > > { "DSDT", "", "", "<=", "5", "", "", "" }, : > > }; : > > static struct acpi_table_desc Compaq_ViperII[] = { : > > { "FACP", "COMPAQ", "VIPER II", "<=", "06040000", "PTL", "<=", "000F4240" }, : > > }; : > : > *snip* : > : > If space is a concern, you can enable (i.e. compile-in) quirks by : > using kernel options, like: : > : > options ACPI_QUIRK_ABIT_BP6 : > : > and : > : > #ifdef ACPI_QUIRK_ABIT_BP6 : > static struct acpi_table_desc Abit_BP6[] = { : > { "FACP", "AWARD", "AWRDACPI", "<=", "30302e31", "", "", "" }, : > }; : > #endif : > : > You put all three of them in GENERIC and people can add or remove them : > from their own kernel configuration to fit their needs (and save space). : > If the quirks are in MI files, then this also avoids that i386 quirks : > end up in amd64 or ia64 kernels. : : There will be about 100-300 of these. :) All the more reason to have them in a form that can easily be subset and takes the tedium (== error possibilities) out of the loop :-) Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040511.183538.13771005.imp>