Date: Mon, 20 Aug 2001 19:52:30 +0300 From: Peter Pentchev <roam@ringlet.net> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: Akinori MUSHA <knu@iDaemons.org>, portmgr@FreeBSD.org, ports@FreeBSD.org Subject: Re: bsd.port.mk: renaming cookie files Message-ID: <20010820195230.A756@ringworld.oblivion.bg> In-Reply-To: <3B81389A.167A5788@FreeBSD.org>; from sobomax@FreeBSD.org on Mon, Aug 20, 2001 at 07:19:38PM %2B0300 References: <86snernc9l.wl@archon.local.idaemons.org> <3B81389A.167A5788@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 20, 2001 at 07:19:38PM +0300, Maxim Sobolev wrote:
> Akinori MUSHA wrote:
>
> > Hi,
> >
> > I'd suggest including ${PKGNAME} in the name of each cookie file, so
> > that a port would never install the stuff built in the outdated
> > working directory.
> >
> > With the following patch, bsd.port.mk will not think a port is already
> > built when the PKGNAME doesn't match that of what is built in the
> > WRKDIR.
> >
> > Any comments?
>
> Nice idea, but I think that we can go further down the road and change WRKDIR to be
> ${WRKDIRPREFIX}${.CURDIR}/work-${PKGNAME}. This way we will also protect packages
> whose distfiles were updated without version bump (hence WRKSRC remains the same) and
> those that doesn't have version number in their WRKSRC at all (e.g. XFree86) - you
> know unpacking new version on top of older one can give number of weird problems
> raging from make (1) not rebuiling all targets to configure script picking pieces of
> all setup via config.cache file. For compatibility purposed bsd.ports.mk could be
> tweaked to create work --> work-${PKGNAME}symlink in the ports's top directory.
>
> What do you think?
Maybe one level deeper: work/${PKGNAME}, so the work/ portion remains
the same, allowing a 'make clean' to clean everything. I often stumble
across a work/ directory left from a previous version, and I like
the ability of the recursive 'make clean' to remove all such beasties
for all dependencies.
G'luck,
Peter
--
This sentence would be seven words long if it were six words shorter.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010820195230.A756>