Date: Sat, 11 May 2002 13:06:12 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: KOMATSU Shinichiro <koma2@jiro.c.u-tokyo.ac.jp>, freebsd-current@FreeBSD.ORG, ports@FreeBSD.ORG, Riccardo Torrini <riccardo@torrini.org>, Garrett Rooney <rooneg@electricjellyfish.net> Subject: Re: bsd.port.mk dependency loop checking patch (Re: Who broke 'make clean' for ports ?) Message-ID: <20020511130611.A55218@xor.obsecurity.org> In-Reply-To: <3CDD1605.38B25E9D@FreeBSD.org>; from sobomax@FreeBSD.org on Sat, May 11, 2002 at 04:00:53PM %2B0300 References: <XFMail.20020510190126.riccardo@torrini.org> <20020510172656.GD13627@dan.emsphone.com> <20020510173132.GA46688@electricjellyfish.net> <20020511090904.69E5B1949@taro.c.u-tokyo.ac.jp> <3CDD1605.38B25E9D@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 11, 2002 at 04:00:53PM +0300, Maxim Sobolev wrote: > KOMATSU Shinichiro wrote: > >=20 > > (add To: ports@freebsd.org) > >=20 > > From: Garrett Rooney <rooneg@electricjellyfish.net> > > Subject: Re: Who broke 'make clean' for ports ? > > Date: Sat, May 11, 2002 at 02:31:32AM JST > >=20 > > > there's a circular dependency that was just introduced to gettext. > > > gettext now depends on expat, which depends on gmake, which depends on > > > gettext. > >=20 > > Recently, I wrote a patch for bsd.port.mk that checks circular dependen= cy. > > If a dependency loop is found, it gives you a warning and > > does not invoke 'make' process any further. > >=20 > > Someone, please test the patch below. > > If no problem is found, I will send-pr(8). >=20 > I don't think that we really need such patch. In 99.9999% of cases it > would just waste CPU cycles. Circular dependency is a bug and as such > it doesn't need to be a supported "special case". Actually it would be useful to have this functionality somewhere. I recently spent a couple of hours trying to track down a circular dependency I had introduced via a bsd.port.mk patch. The main symptom was that the make_index script would just go into a loop and exhaust memory. I ended up finding it by adding all sorts of debugging printfs to the perl script, but this was pretty ugly. Kris --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE83XmvWry0BWjoQKURAjaWAJ935jkBQZvlkwEppEjrPHeJlR1pRgCg2gc5 AuwsBvFkeHTEpgaQVKTIJG8= =ucTX -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020511130611.A55218>