From owner-svn-src-all@freebsd.org Sat Aug 8 19:05:47 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ECA339B6524; Sat, 8 Aug 2015 19:05:46 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qg0-x235.google.com (mail-qg0-x235.google.com [IPv6:2607:f8b0:400d:c04::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A730F1F21; Sat, 8 Aug 2015 19:05:46 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by qgj62 with SMTP id 62so69792134qgj.2; Sat, 08 Aug 2015 12:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=3rPT9dKCUOQs485LkaUfUoQuJBw/h4+yWaUndG3R9ws=; b=WxtFUekYpNggFkZSt4C7gSZ1wJCGYSKV9QfzaG+iNZcsEl4nPB6dVAJYDpez2AKhZV d0xP8hOmNmhjlcUSNfRAbmuxqkXkhEGwn94Rn76Hu/onYvpCfztRiSbkQrnA79bH6KMU B2pMI8YZEWaYkvbyE45HTeeQvrLKOM3tqndvkr7zaTVPSokGpR6f5PAOaecoys6Byude slxGUm2fcDU9awYXMOxtbe6p0f6QDk+VaabfIfFJYXYwCR3u2oefU/ADF4j3YMbEbXLg hGAMNZRFH94wmFEvnIowr6LB9P2LfR7PvIz+UVv86UfC40/obcZCrdWuAkeUAVjo8Jlg Yd8g== X-Received: by 10.140.133.16 with SMTP id 16mr26789592qhf.43.1439060745844; Sat, 08 Aug 2015 12:05:45 -0700 (PDT) Received: from kan ([2601:18f:0:1570:226:18ff:fe00:232e]) by smtp.gmail.com with ESMTPSA id 1sm6945895qhu.11.2015.08.08.12.05.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Aug 2015 12:05:44 -0700 (PDT) Date: Sat, 8 Aug 2015 15:05:39 -0400 From: Alexander Kabaev To: Ed Schouten Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285910 - in head: lib/libc/sys sys/kern sys/sys Message-ID: <20150808150539.0b43cfcd@kan> In-Reply-To: <201507271317.t6RDHwpj067194@repo.freebsd.org> References: <201507271317.t6RDHwpj067194@repo.freebsd.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/BbKdeIG_rtzy/3KPa5m0ARF"; protocol="application/pgp-signature" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2015 19:05:47 -0000 --Sig_/BbKdeIG_rtzy/3KPa5m0ARF Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 27 Jul 2015 13:17:58 +0000 (UTC) Ed Schouten wrote: > Author: ed > Date: Mon Jul 27 13:17:57 2015 > New Revision: 285910 > URL: https://svnweb.freebsd.org/changeset/base/285910 >=20 > Log: > Make shutdown() return ENOTCONN as required by POSIX, part deux. > =20 > Summary: > Back in 2005, maxim@ attempted to fix shutdown() to return ENOTCONN > in case the socket was not connected (r150152). This had to be rolled > back (r150155), as it broke some of the existing programs that depend > on this behavior. I reapplied this change on my system and indeed, > syslogd failed to start up. I fixed this back in February (279016) > and MFC'ed it to the supported stable branches. Apart from that, > things seem to work out all right. Since at least Linux and Mac OS X > do the right thing, I'd like to go ahead and give this another try. > To keep old copies of syslogd working, only start returning ENOTCONN > for recent binaries. I took a look at the XNU sources and they seem > to test against both SS_ISCONNECTED, SS_ISCONNECTING and > SS_ISDISCONNECTING, instead of just SS_ISCONNECTED. That seams > reasonable, so let's do the same. Test Plan: This issue was uncovered > while writing tests for shutdown() in CloudABI: > https://github.com/NuxiNL/cloudlibc/blob/master/src/libc/sys/socket/shutd= own_test.c#L26 > Reviewers: glebius, rwatson, #manpages, gnn, #network Reviewed By: > gnn, #network Subscribers: bms, mjg, imp=20 > Differential Revision: https://reviews.freebsd.org/D3039 >=20 Hi Ed, this commit broke more than just syslogd. rtsol and rtsold both are victims of the change as they are trying to shutdown unconnected raw sockets to make then 'send-only' and fail. --=20 Alexander Kabaev --Sig_/BbKdeIG_rtzy/3KPa5m0ARF Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJVxlMEXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDNUY3RDk5NTk5QjY0MUUxM0M1MTU2OTEw NzEzMjI5OTkyNzkyRTdFAAoJEAcTIpmSeS5+uZ0P/1PY2Qg259PwCr8IU/ASxOhf LqGSGAkjdXMIua65wCjpuFFLAmdxeRpew/ES1bCKUc/VFyGMSzwo9gAPk8LJD7+1 l+CK1s6ouvf4fSXa7YPTyfDDotu+LeS1yoH401GL58lDe1Iyr6xZkmEb8wNAriS/ EH0bhw5bpG9sVXHCq403BBbRN9jQrQ8YKU2duuMPa15pxSlFugN1gXxl3O7r3MIW 12InxhmFPX8B+lzKx2xbemzh0rBJtgV1bv+cVh7DenqPHyPN28SY4jhsxRUdiEZy 6+4C2lO48jgb6NOfAtWnMQgW/20J2T71mh3L6ZIh3BQ8LMQtOzLsd+nAZ/mqe3/t X0PYhepDdmehKGVXgjuwVnkWtoILF9KmVBzkkd/A26aVpfFY/lVh+K4FsVz8lCtN VJNGehrD+5s1AnZ8nYMk3weq7wDihqfTYXELdZxy/RKgNwVRysg7H3nU89iLtSOh YvpC0ThTUm8Bu4WhStRcn/P0FfxqOrrvvl+Vtv3UMQJIvU1NmeSPW5G5H3lUWkHm NDwmV5cijwgfyEzeVJ9COYmxLiL0lbZxYHdyr5j+Z7PzB82qkINL92GD5KPux3RB MzTDqUL/ET9inlfJ/Pj3vynRmsG+cF3J70L4/TRVUmnw4QOiCM5EYrm2X6hAjlU1 v8ZQsLpIswPNWrFZAiqm =NIzU -----END PGP SIGNATURE----- --Sig_/BbKdeIG_rtzy/3KPa5m0ARF--