From owner-svn-ports-head@freebsd.org  Sat Aug  6 07:36:04 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45CF9BB0A2E;
 Sat,  6 Aug 2016 07:36:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 3B4091DDE;
 Sat,  6 Aug 2016 07:36:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 39B8D1296; Sat,  6 Aug 2016 07:36:04 +0000 (UTC)
Date: Sat, 6 Aug 2016 07:36:04 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: Pawel Pekala <pawel@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r419716 - in head/games: . zdoom
Message-ID: <20160806073604.GD53097@FreeBSD.org>
References: <201608052308.u75N8bQf092339@repo.freebsd.org>
 <02F62285C025519217DB3167@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <02F62285C025519217DB3167@atuin.in.mat.cc>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Aug 2016 07:36:04 -0000

On Sat, Aug 06, 2016 at 02:01:32AM +0200, Mathieu Arnold wrote:
> +--On 5 ao??t 2016 23:08:37 +0000 Pawel Pekala <pawel@FreeBSD.org> wrote:
> | +PLIST_FILES=	bin/${PORTNAME} \
> | +		%%DATADIR%%/${PORTNAME}.pk3
> 
> This should be:
> PLIST_FILES=	bin/${PORTNAME} \
> 		${DATADIR}/${PORTNAME}.pk3

Why?  Now it looks inconsistent:

% make -V PLIST_FILES
bin/zdoom  /usr/local/share/zdoom/zdoom.pk3

If your point was to avoid plist substitutions for some reason (if they do
not work in PLIST_FILES it looks like a bug that should be fixed instead),
${DATADIR_REL} still suits better.

./danfe