From owner-svn-src-head@freebsd.org  Tue Dec 18 11:46:04 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 856B5134E089;
 Tue, 18 Dec 2018 11:46:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 206718F620;
 Tue, 18 Dec 2018 11:46:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 0EE3E1D07F; Tue, 18 Dec 2018 11:46:04 +0000 (UTC)
Date: Tue, 18 Dec 2018 11:46:04 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Toomas Soome <tsoome@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r342151 - head/stand/libsa/zfs
Message-ID: <20181218114603.GA65077@FreeBSD.org>
References: <201812160858.wBG8wFSd032964@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201812160858.wBG8wFSd032964@repo.freebsd.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: 206718F620
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.82 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.99)[-0.986,0];
 NEURAL_HAM_LONG(-0.98)[-0.984,0];
 NEURAL_HAM_SHORT(-0.85)[-0.848,0];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 11:46:04 -0000

On Sun, Dec 16, 2018 at 08:58:15AM +0000, Toomas Soome wrote:
> New Revision: 342151
> URL: https://svnweb.freebsd.org/changeset/base/342151
> 
> Log:
>   loader: zfs reader should not probe partitionless disks
>   
> @@ -527,10 +527,11 @@ zfs_probe_dev(const char *devname, uint64_t *pool_guid
>  	pa.fd = open(devname, O_RDONLY);
>  	if (pa.fd == -1)
>  		return (ENXIO);
> -	/* Probe the whole disk */
> -	ret = zfs_probe(pa.fd, pool_guid);
> -	if (ret == 0)
> -		return (0);
> +	/*
> +	 * We will not probe the whole disk, we can not boot from such

I think you mean "cannot" here.

> +	 * disks and some systems will misreport the disk sizes and will
> +	 * hang while accessing the disk.
> +	 */

./danfe