From nobody Tue Apr 21 16:44:39 2026 X-Original-To: freebsd-testing@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g0SrR3m5dz6YV7l for ; Tue, 21 Apr 2026 16:44:55 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g0SrQ6tpfz3sG4 for ; Tue, 21 Apr 2026 16:44:54 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-67179ed133dso5021306a12.2 for ; Tue, 21 Apr 2026 09:44:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776789893; cv=none; d=google.com; s=arc-20240605; b=ewD27BYaosO7cDmxZ9ME+udf3qhxClCBrMVO6rVIpUmCuEQ+Ig1iVLE8PZvslbgLNV pySCsO991gHTc+XA+k0mmwE2oZgKA+xJoAeHhM9f4lPUTfrXPcQH/DboYOH3kEFGEvE+ k7H2ypOh8ZK4pLCCBPqhgAMuzDUlHGE6RVASFjO2lKyuTzfhfKZmoUQjJ42m7shMe6ox PbDgLQYnFfeO0TbibUgjg45E8SRSjhyWdcnQ0MH5qNmRhWkh04bjJRCFF1nkyOr70PPL BLfCmyI2vZdF6InAc25JNfdCYf5i0JAOD3Nr+84RNI6wfx2g9Kk4QcyDxWnNKwsvuNPk yZHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=ixORyEo3ZTn3anOSQseV5ngsM4RSisVEa6IV/BvPi8A=; fh=PQPw1mCwQriwC61i4/6EVcEgbLxf4fHtKP5V2bgwYVk=; b=QlmRfMd8yt0zrpMW+YnTtPd//fJkrTTl0GOQiumSWe69jzgUqZ/rELffWJP3hyti/z OWE2WaBX8P2x08Ar47iPvy/NbvMP29QvuE2JjJQXgqQKFwYGTRPX8M/Zn0PxxRDcWcSu pIXRIDIG5x5+yMKKmQS1DCIQc83+76r3/Gnaa2k/3EAILzIO/zYZZnKthqgukb27aHG0 2lAiG4OrveSDUfNAXbNBSxVoom7gKNnNVoW/uGUZrdNsxYwIANkmv4UNScCEzHmxYzmQ VWt1nbvnOarlQcRpDoDDq3aLojCi9vB3WswIhoFRZpKrIIwhh9NoyDAl2klYmwx8XtRd Wlnw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776789893; x=1777394693; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ixORyEo3ZTn3anOSQseV5ngsM4RSisVEa6IV/BvPi8A=; b=jV9lnQDqZQ2RQ3dCuvch0lnFz6qDfHwV93Bc3CfoQmm2tiR8+zU0NJG145J9Ut4ZH2 jdRQcrE6620B3qGGe9tLUDegRfbVGNI5feLDgcj1uUP3OuRAymlVVkklhE4sL8+NwQCa j+xrMtTqTns+d82ckRXFLWwVnjcAJKITMpDiPmPvNZgE/cCdqrGaVJHuasHH81XaGVEm YBgphEXrMj0S0if6Ma+CovSfOJW+nWtrslbKtXySdGM51Qqm16dozFHxQ+EI3Z6UzepT SGvOB9o2gbAvPLNSCoSy3a1D2FJjKPysp9jUn73a3MV+iQrm1tpDZP8cVol1qAF8qs2U Q9nQ== X-Gm-Message-State: AOJu0YxELu1FbC9i9hP8uagzS1cRwgTu4iZtwfYSUOlBAQrR1ZOF2PEl R01WiP0fiviD880L7a9XU9PA42KR/gujeVPrQRP8/ygtSlab55ahy6AgTdZhKkHVWfwejZQTwhm U94gAA57wp6O+4mOyc80OXHKRLWOUvak= X-Gm-Gg: AeBDieu/AC07Zj2g8fhHni1E0imP9SDk/aEeIOO69lFvDdN9PGAETnotzPQsGKfqzaY tRN4wFFgK1+hLjOO2YjPf8g8d6Acy6u/MuQQd4jpztaa4AYb6oqvjb+w8RrdvER3yT4pCc4f4bu zYLk+ysg06E/JUICITZaU4l/OkSn4gHyLuynMVM6rHXjNsfeE7lqgvYxtTBY6nlAqfWGheFvY4P OUlrKVkKZXiB0aRypJ/LDboDcUA3oVi0vGAOQE2enW/mM8F2KW1L6GzrwnC6Mipmin1aIybxadU DSZpqVu5squvK/tkHJZ0T36XrEm9lkIlN2YJGB6hA35y2UKuIzGb4OzHPaBTO/XArY7qpKB/nyI EQvs= X-Received: by 2002:a05:6402:2b8d:b0:676:9c70:66d0 with SMTP id 4fb4d7f45d1cf-6769c7068f1mr2023759a12.16.1776789893072; Tue, 21 Apr 2026 09:44:53 -0700 (PDT) List-Id: Testing List-Archive: https://lists.freebsd.org/archives/freebsd-testing List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-testing@freebsd.org Sender: owner-freebsd-testing@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Tue, 21 Apr 2026 10:44:39 -0600 X-Gm-Features: AQROBzBQQ2p5LEF-KMsCv8Kzpq5g4J7MhyZ63kKDiQR_w_sGddaBXv2vsvO2k8I Message-ID: Subject: Re: pjdfstest integration To: Mark Johnston Cc: freebsd-testing@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4g0SrQ6tpfz3sG4 X-Spamd-Bar: ---- On Tue, Apr 21, 2026 at 10:41=E2=80=AFAM Mark Johnston = wrote: > > On Tue, Apr 21, 2026 at 09:41:31AM -0600, Alan Somers wrote: > > On Tue, Apr 21, 2026 at 9:11=E2=80=AFAM Mark Johnston wrote: > > > > > > Hi, I noticed that we install pjdfstest to /usr/tests/sys/pjdfstest, > > > but: > > > - it's not hooked up to the test suite, i.e., > > > "kyua test -k /usr/tests/Kyuafile" doesn't run it, > > > - contrib/pjdfstest doesn't seem to be updated regularly, > > > - the configuration is hard-coded, i.e., I can't easily run it agains= t a > > > filesystem of my choice. > > > > > > How hard would it be to parameterize the tests so that we can run the > > > tests again a list of filesystems? For each filesystem we'd have som= e > > > little script that sets up some scratch space, creates an empty > > > filesystem and points pjdfstest at it. In some cases we'd need the t= est > > > runner to specify some additional variables, e.g., for p9fs you want = the > > > test runner to provide a share, as we currently only support the virt= io > > > transport. I'm not sure if kyua can pass variables to a TAP test, so > > > the solution might be to wrap each pjdfstest run with an ATF test cas= e > > > which handles the setup. > > > > > > Is anyone interested in working on these things? > > > > Yes, yes and yes. > > > > I was indeed working on a change to pjdfstest which, among other > > things, would read a config file for each file system under test. The > > config file specifies things like whether posix_fallocate is supported > > on that file system and which file flags are supported. The change > > also drastically speeds up pjdfstest's runtime. > > > > We did that as part of GSoC 2022. The status of the project is that > > it's 99% complete, but requires somebody to comb through 4000 SLOC > > line by line to make sure nothing got left out. That's very tedious, > > which is why nobody has done it yet. I would LOVE to get it finished, > > but I've never made the time. > > The rewrite also relies on some ugly macro syntax. We did that > > deliberately to save time, but it does make the code ugly, and a > > little bit harder to review. It might be worth investing the time to > > rewrite those macros more cleanly. > > > > Using the new pjdfstest, it would be quite easy to add an ATF test for > > each file system. atf-sh would format the file system under test, > > then call pjdfstest with the appropriate per-filesystem config file. > > Do you have a pointer to this work anywhere? I can't promise to > complete it, but I'm pretty motivated to stand something up for p9fs. It's at git@github.com:musikid/pjdfstest.git . What do you think is the best path forward? I could publish a 0.1 release now, and get this into ports, while you work on the ATF part. Then we could slowly open a series of reviews that delete the old sh-based stuff.