From owner-freebsd-net@freebsd.org Wed Sep 23 15:40:33 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6BC4A06853 for ; Wed, 23 Sep 2015 15:40:33 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com [IPv6:2607:f8b0:4001:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B5B5C1A92; Wed, 23 Sep 2015 15:40:33 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igxx6 with SMTP id x6so30404945igx.1; Wed, 23 Sep 2015 08:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=PZGl/Z3HlUDzrv3MdHljPZAu2CZeaNs6sbSXXhODLgY=; b=YOQLwwZyGD8ck5dSYD1vAhB0FNs8yKdMZgkFBizDg9vtniCKuEXRHubieqleTd2AGI qzOo2jI4wvcxXu4iqLwFqR+y+9jA5NmW8i/xJ9vMWn26vb7EaJ26EjBlbFhfM4fhvRxA eTHA8T4bF2I8uSD3+oDwn7PxH43Uoa8xB2j6ZDYxnIeLPzLm8D2nlxteiYuIsUXAWqw4 WN5CU8jX74NGfk8DXxIa2NpjPSE2GvThY6CF+zz9sDkbuZWld9dt2HdMukSjB44g7k1p 8yFmIoqdGJK59sGUhAaLaHD2H6xg4wn1oqi34mRr87aEiV7KdIjNXHkTqKC1ZOXHZECG eolg== MIME-Version: 1.0 X-Received: by 10.50.45.33 with SMTP id j1mr22857859igm.61.1443022833229; Wed, 23 Sep 2015 08:40:33 -0700 (PDT) Received: by 10.36.28.208 with HTTP; Wed, 23 Sep 2015 08:40:33 -0700 (PDT) In-Reply-To: <560250B9.3080002@FreeBSD.org> References: <56011276.4060206@FreeBSD.org> <560250B9.3080002@FreeBSD.org> Date: Wed, 23 Sep 2015 08:40:33 -0700 Message-ID: Subject: Re: page fault in tcp_do_segment (r287759 suspected) From: Adrian Chadd To: Andriy Gapon Cc: freebsd-net , "George V. Neville-Neil" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 15:40:34 -0000 Yes, file a bug. :) -a On 23 September 2015 at 00:11, Andriy Gapon wrote: > On 22/09/2015 11:33, Andriy Gapon wrote: >> That code actually looks like the following DTrace probe a few lines below: >> >> TCP_PROBE3(debug__input, tp, th, mtod(m, const char *)); >> >> So, it seems like 'm' could be NULL here. >> I see two places in tcp_do_segment() where m gets assigned with NULL followed by >> goto drop. If I had to guess then my guess would be that one of those code >> paths was taken. >> Since those NULL assignments were there for more than a year, then I would guess >> that the addition of the probe is to blame: >> https://svnweb.freebsd.org/base?view=revision&revision=287759 > > Should I file a bug report about this? > Does anyone has suggestion for a simple fix? > > -- > Andriy Gapon > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"