From owner-svn-ports-all@freebsd.org Wed Apr 24 14:21:51 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B000159A2B6; Wed, 24 Apr 2019 14:21:51 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) by mx1.freebsd.org (Postfix) with ESMTP id 01A548EC87; Wed, 24 Apr 2019 14:21:49 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.15.2/8.15.2) with ESMTP id x3OELh3Q071714; Wed, 24 Apr 2019 07:21:43 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.15.2/8.15.2/Submit) id x3OELhac071713; Wed, 24 Apr 2019 07:21:43 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Wed, 24 Apr 2019 07:21:43 -0700 From: Greg Lewis To: Mathieu Arnold Cc: Greg Lewis , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r499685 - head/java/openjdk8 Message-ID: <20190424142142.GA71685@misty.eyesbeyond.com> References: <201904222052.x3MKqqVH050067@repo.freebsd.org> <20190423074622.puxd7fibzxx3xvmr@atuin.in.mat.cc> <20190423162725.GA57876@misty.eyesbeyond.com> <20190423165837.zsc7awsmfh423nab@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190423165837.zsc7awsmfh423nab@ogg.in.absolight.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 01A548EC87 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.974,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2019 14:21:51 -0000 On Tue, Apr 23, 2019 at 06:58:37PM +0200, Mathieu Arnold wrote: > On Tue, Apr 23, 2019 at 09:27:25AM -0700, Greg Lewis wrote: > > On Tue, Apr 23, 2019 at 09:46:22AM +0200, Mathieu Arnold wrote: > > > On Mon, Apr 22, 2019 at 08:52:52PM +0000, Greg Lewis wrote: > > > > Author: glewis > > > > Date: Mon Apr 22 20:52:52 2019 > > > > New Revision: 499685 > > > > URL: https://svnweb.freebsd.org/changeset/ports/499685 > > > > > > > > Log: > > > > Always depend on fontconfig > > > > > > > > PR: 203862 > > > > Submitted by: Dominik Lisiak > > > > > > You need to bump PORTREVISION when you change the runtime dependencies. > > > > I didn't bump it since this is a build fix. I.e., we fail the configure > > step without the dependency. If that still requires a PORTREVISION bump > > then I think the porters handbook could use with some clarification on > > the topic. > > Then it does not, but nothing in the commit message could give any hint > that it was fixing the build, and not simply registering a dependency > correctly. That's fair. I didn't pull in the context from the PR to the commit message. Will try to do so in future. -- Greg