From owner-svn-src-head@freebsd.org Fri May 27 07:42:05 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60C36B4C3B1; Fri, 27 May 2016 07:42:05 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (mail.turbocat.net [IPv6:2a01:4f8:d16:4514::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2AF2C1F41; Fri, 27 May 2016 07:42:05 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (unknown [62.141.129.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 725F51FE024; Fri, 27 May 2016 09:42:02 +0200 (CEST) Subject: Re: svn commit: r300718 - in head/sys: kern sys To: Ian Lepore , Gleb Smirnoff References: <201605260841.u4Q8ft9r045564@repo.freebsd.org> <20160526213716.GK58287@FreeBSD.org> <1464303288.1204.65.camel@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Hans Petter Selasky Message-ID: <57bc9380-3183-a0c6-1a44-7e1abb8bede7@selasky.org> Date: Fri, 27 May 2016 09:45:21 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1464303288.1204.65.camel@freebsd.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2016 07:42:05 -0000 On 05/27/16 00:54, Ian Lepore wrote: > On Thu, 2016-05-26 at 14:37 -0700, Gleb Smirnoff wrote: >> Hans, >> >> On Thu, May 26, 2016 at 08:41:55AM +0000, Hans Petter Selasky wrote: >> H> Author: hselasky >> H> Date: Thu May 26 08:41:55 2016 >> H> New Revision: 300718 >> H> URL: https://svnweb.freebsd.org/changeset/base/300718 >> H> >> H> Log: >> H> Add support for boolean sysctl's. >> H> >> H> Because the size of bool can be implementation defined, make a >> bool >> H> sysctl handler which handle bools. Userspace sees the bools like >> H> unsigned 8-bit integers. Values are filtered to either 1 or 0 >> upon >> H> read and write, similar to what a compiler would do. >> H> >> H> Requested by: kmacy @ >> H> Sponsored by: Mellanox Technologies >> >> Would be nice if sysctl(8) would explicitly display them as "true" or >> "false" >> instead of 0 and 1. Now the userland can't differ them from uint8_t >> oids. > > If it displayed them that way, then users would want to set them using > the true/false strings too. If you start down that path you eventually > end up adding support for 0/1/true/false/yes/no/on/off, and if you > don't do that in exactly once place you end up with some oids accepting > all the values and others accepting only some of them, and the user > experience is confusing at best. > Hi, My initial thought was that bool support should be in the kernel only, because sizeof(bool) varies. So it is not directly compatible to userspace. Even though we might not support true/false/on/off strings, do you think bool is worth it's own CTL type, which falls back to CTLTYPE_U8 ? --HPS