From owner-svn-src-all@FreeBSD.ORG  Sat Sep 20 06:49:15 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C11A46C1;
 Sat, 20 Sep 2014 06:49:15 +0000 (UTC)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "vps1.elischer.org",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 915D63CF;
 Sat, 20 Sep 2014 06:49:15 +0000 (UTC)
Received: from jre-mbp.elischer.org
 (ppp121-45-253-99.lns20.per2.internode.on.net [121.45.253.99])
 (authenticated bits=0)
 by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id s8K6n0k5023133
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
 Fri, 19 Sep 2014 23:49:07 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Message-ID: <541D2356.8040403@freebsd.org>
Date: Sat, 20 Sep 2014 14:48:54 +0800
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Will Andrews <will@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r271771 - in head: bin/csh etc/mail lib/libc
 usr.bin/grep usr.sbin/mtree
References: <201409181441.s8IEfvR1075223@svn.freebsd.org>
In-Reply-To: <201409181441.s8IEfvR1075223@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Sep 2014 06:49:15 -0000

On 9/18/14, 10:41 PM, Will Andrews wrote:
> Author: will
> Date: Thu Sep 18 14:41:57 2014
> New Revision: 271771
> URL: http://svnweb.freebsd.org/changeset/base/271771
>
> Log:
>    Fix incremental builds involving non-root users with read-only source files.
>    
>    Makefiles should not assume that source files can be overwritten.  This is the
>    common case for Perforce source trees.

I'm concerned that just adding -f may not really be fixing the problem..
why are the files getting overwritten? I'm not sure forcing an 
overwrite is teh right answer to read-only sources.


>   iconv.h: ${.CURDIR}/iconv_stub.h
> -	cp ${.CURDIR}/iconv_stub.h ${.TARGET}
> +	cp -f ${.CURDIR}/iconv_stub.h ${.TARGET}
>   .endif
>   .endif
>