Date: Tue, 12 Apr 2005 13:57:23 +0900 (JST) From: Keiichi SHIMA <keiichi@iijlab.net> To: snap-users@kame.net, gnn@freebsd.org Cc: sam@errno.com Subject: Re: (KAME-snap 9008) Please review this diff... Message-ID: <20050412.135723.92413233.keiichi@iijlab.net> In-Reply-To: <m2hdigulfe.wl%gnn@neville-neil.com> References: <m2hdigulfe.wl%gnn@neville-neil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, From: gnn@freebsd.org Date: Sat, 09 Apr 2005 22:30:45 +0900 > I would like to check in the following diff against FreeBSD-CURRENT > and to get feedback from the Kame folks on the general usefulness of > these fixes. All changes are against icmp6.c. > > The first part of the diff removes dead code as I suspect MCLBYTES, > the size of a cluster, will never be less than 48, which is the size > of maxlen set above those lines. I checked the log when the code was added, but found no useful information. Maybe it is intended to handle a special architecture which MCLBYTES is very small. I don't know such an architecture, though... > The second part checks for error returns from the duplication of the > packets before starting to copy things around. These error checks seems correct. We will update our code too. Thank you for your pointing them out. Regards, --- Keiichi SHIMA IIJ Research Laboratory KAME project
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050412.135723.92413233.keiichi>