From owner-freebsd-current@FreeBSD.ORG Wed Aug 4 00:21:48 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86420106568E for ; Wed, 4 Aug 2010 00:21:48 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.freebsd.org (Postfix) with ESMTP id 61AC78FC18 for ; Wed, 4 Aug 2010 00:21:48 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.4/8.14.4) with ESMTP id o740Lkc5076348; Tue, 3 Aug 2010 17:21:46 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.4/8.14.4/Submit) id o740LjA2076347; Tue, 3 Aug 2010 17:21:45 -0700 (PDT) (envelope-from sgk) Date: Tue, 3 Aug 2010 17:21:45 -0700 From: Steve Kargl To: Thomas Dickey Message-ID: <20100804002145.GA76309@troutmask.apl.washington.edu> References: <4C585E6C.7080006@elischer.org> <20100803214005.GA539@saltmine.radix.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100803214005.GA539@saltmine.radix.net> User-Agent: Mutt/1.4.2.3i Cc: FreeBSD Current , Julian Elischer Subject: Re: [patch] big whitespace cleanup in sys/kern/* X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2010 00:21:48 -0000 On Tue, Aug 03, 2010 at 05:40:05PM -0400, Thomas Dickey wrote: > On Tue, Aug 03, 2010 at 11:22:36AM -0700, Julian Elischer wrote: > > On 8/3/10 2:34 AM, pluknet wrote: > > >Hi. > > > > > >I looked into sys/kern/* files to fix a bunch of common w/s style issues > > >(221): > > >- leading space before label; > > >- leading space(s) before; > > >- space(s) instead of(s); > > >- space(s) in blank like. > > > > > >I tried to be conservative and didn't touch semi-contrib files and > > >those with its own style. > > >Here is a diff I'd like someone look into and check in if there will > > >no objections. > > > > The style guide suggests against wholesale cleanups and we have > > generally avoided them due to teh fact that they tend to obfuscate diffs. > > The idea being that we clean as we go.. > > however it may be time for one.. I'd leave it to others to decide. > > I'm curious why there's no mention of using 'indent' (with appropriate > settings...). > Because there is no set of appropriate settings for indent(1) to reproduce style(9). -- Steve