From owner-cvs-all Sun Jul 7 14:41:34 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70CBD37B400; Sun, 7 Jul 2002 14:41:31 -0700 (PDT) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA5FB43E4A; Sun, 7 Jul 2002 14:41:30 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.12.3/8.12.3) with ESMTP id g67Lh10M023883; Sun, 7 Jul 2002 14:43:04 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Message-Id: <200207072143.g67Lh10M023883@gw.catspoiler.org> Date: Sun, 7 Jul 2002 14:42:07 -0700 (PDT) From: Don Lewis Subject: Re: cvs commit: src/sbin/dump tape.c traverse.c To: brooks@one-eyed-alien.net Cc: iedowse@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <20020707135330.A5949@Odin.AC.HMC.Edu> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 7 Jul, Brooks Davis wrote: > On Sun, Jul 07, 2002 at 05:30:21AM -0700, Ian Dowse wrote: >> iedowse 2002/07/07 05:30:21 PDT >> >> Modified files: >> sbin/dump tape.c traverse.c >> Log: >> Fix some printf format errors. > > Do we really want to fix printf errors wwith %qd? A cast to intmax_t > and %jd is at least C99 compliant where as %qd is a FreeBSDism. There were already a bunch of %qd formats in the code, so the patch I suggested changed a bunch of %d formats associated with int64_t values to match. I certainly wouldn't object if someone wanted to convert all the %qd formats to %jd. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message