From owner-cvs-all@FreeBSD.ORG  Sat Feb  3 17:39:07 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9479D16A400;
	Sat,  3 Feb 2007 17:39:07 +0000 (UTC)
	(envelope-from antoine@peanut.dreadbsd.org)
Received: from peanut.dreadbsd.org (peanut.dreadbsd.org [82.67.196.50])
	by mx1.freebsd.org (Postfix) with ESMTP id EED3813C491;
	Sat,  3 Feb 2007 17:39:06 +0000 (UTC)
	(envelope-from antoine@peanut.dreadbsd.org)
Received: from peanut.dreadbsd.org (localhost [127.0.0.1])
	by peanut.dreadbsd.org (8.13.8/8.13.8) with ESMTP id l13HNkHB036459;
	Sat, 3 Feb 2007 18:23:46 +0100 (CET)
	(envelope-from antoine@peanut.dreadbsd.org)
Received: (from antoine@localhost)
	by peanut.dreadbsd.org (8.13.8/8.13.8/Submit) id l13HNjNa036458;
	Sat, 3 Feb 2007 18:23:45 +0100 (CET) (envelope-from antoine)
Date: Sat, 3 Feb 2007 18:23:45 +0100
From: Antoine Brodin <antoine.brodin@laposte.net>
To: Warner Losh <imp@FreeBSD.org>
Message-Id: <20070203182345.c64553e6.antoine.brodin@laposte.net>
In-Reply-To: <200702031633.l13GXmGn001131@repoman.freebsd.org>
References: <200702031633.l13GXmGn001131@repoman.freebsd.org>
X-Mailer: Sylpheed 2.3.1 (GTK+ 2.10.9; i386-portbld-freebsd7.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb uipaq.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Feb 2007 17:39:07 -0000

Warner Losh <imp@FreeBSD.org> wrote:
> imp         2007-02-03 16:33:48 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/usb          uipaq.c 
>   Log:
>   Fix non-use, but not memory leak, of devinfop.  Set the device's
>   description here.  The fix in the PR isn't necessary at all for memory
>   leaks, but we weren't setting the device description.
>   
>   While I'm here, remove some of the obfuscating macros in attach.
>   
>   PR: 108719
>   
>   Revision  Changes    Path
>   1.2       +22 -39    src/sys/dev/usb/uipaq.c

Hi Warner,

devinfop is leaked in the "goto bad;" case isn't it ?

Cheers,

Antoine