From owner-svn-src-head@FreeBSD.ORG Mon Apr 22 06:10:28 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id AB7C2C8A; Mon, 22 Apr 2013 06:10:28 +0000 (UTC) (envelope-from dteske@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 9EDEB1225; Mon, 22 Apr 2013 06:10:28 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.6/8.14.6) with ESMTP id r3M6ASEw021468; Mon, 22 Apr 2013 06:10:28 GMT (envelope-from dteske@svn.freebsd.org) Received: (from dteske@localhost) by svn.freebsd.org (8.14.6/8.14.5/Submit) id r3M6AS1H021467; Mon, 22 Apr 2013 06:10:28 GMT (envelope-from dteske@svn.freebsd.org) Message-Id: <201304220610.r3M6AS1H021467@svn.freebsd.org> From: Devin Teske Date: Mon, 22 Apr 2013 06:10:28 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r249753 - head/usr.sbin/bsdconfig/networking X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2013 06:10:28 -0000 Author: dteske Date: Mon Apr 22 06:10:27 2013 New Revision: 249753 URL: http://svnweb.freebsd.org/changeset/base/249753 Log: Fix two bugs when setting up a plip interface. First, dhcp status was not being properly cleared each iteration of the loop. Second, values weren't properly quoted when sent to the editor function. Modified: head/usr.sbin/bsdconfig/networking/devices Modified: head/usr.sbin/bsdconfig/networking/devices ============================================================================== --- head/usr.sbin/bsdconfig/networking/devices Mon Apr 22 05:52:18 2013 (r249752) +++ head/usr.sbin/bsdconfig/networking/devices Mon Apr 22 06:10:27 2013 (r249753) @@ -99,6 +99,7 @@ while :; do # fallback to reading the active configuration if not configured in # the rc.conf(5) file(s). # + dhcp= _ipaddr= _netmask= _ifconfig=$( f_sysrc_get ifconfig_$interface ) @@ -147,7 +148,7 @@ while :; do # Block on user-configuration of the probed settings f_dialog_menu_netdev_edit \ - $interface $_ipaddr $_netmask "$_options" $dhcp + "$interface" "$_ipaddr" "$_netmask" "$_options" $dhcp # Return to root menu if above returns success [ $? -eq $SUCCESS ] && break