Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Apr 2013 06:10:28 +0000 (UTC)
From:      Devin Teske <dteske@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r249753 - head/usr.sbin/bsdconfig/networking
Message-ID:  <201304220610.r3M6AS1H021467@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dteske
Date: Mon Apr 22 06:10:27 2013
New Revision: 249753
URL: http://svnweb.freebsd.org/changeset/base/249753

Log:
  Fix two bugs when setting up a plip interface. First, dhcp status was not
  being properly cleared each iteration of the loop. Second, values weren't
  properly quoted when sent to the editor function.

Modified:
  head/usr.sbin/bsdconfig/networking/devices

Modified: head/usr.sbin/bsdconfig/networking/devices
==============================================================================
--- head/usr.sbin/bsdconfig/networking/devices	Mon Apr 22 05:52:18 2013	(r249752)
+++ head/usr.sbin/bsdconfig/networking/devices	Mon Apr 22 06:10:27 2013	(r249753)
@@ -99,6 +99,7 @@ while :; do
 	# fallback to reading the active configuration if not configured in
 	# the rc.conf(5) file(s).
 	#
+	dhcp=
 	_ipaddr=
 	_netmask=
 	_ifconfig=$( f_sysrc_get ifconfig_$interface )
@@ -147,7 +148,7 @@ while :; do
 
 	# Block on user-configuration of the probed settings
 	f_dialog_menu_netdev_edit \
-		$interface $_ipaddr $_netmask "$_options" $dhcp
+		"$interface" "$_ipaddr" "$_netmask" "$_options" $dhcp
 
 	# Return to root menu if above returns success
 	[ $? -eq $SUCCESS ] && break



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304220610.r3M6AS1H021467>