From owner-cvs-all  Sun Jul  2  2:52:46 2000
Delivered-To: cvs-all@freebsd.org
Received: from mail.interware.hu (mail.interware.hu [195.70.32.130])
	by hub.freebsd.org (Postfix) with ESMTP
	id 053AB37C0E5; Sun,  2 Jul 2000 02:52:36 -0700 (PDT)
	(envelope-from julian@elischer.org)
Received: from kairo-42.budapest.interware.hu ([195.70.50.106] helo=jules.elischer.org)
	by mail.interware.hu with smtp (Exim 3.12 #1 (Debian))
	id 138gfa-00063s-00; Sun, 02 Jul 2000 12:08:10 +0200
Message-ID: <395F0CE0.41C67EA6@elischer.org>
Date: Sun, 02 Jul 2000 02:52:04 -0700
From: Julian Elischer <julian@elischer.org>
X-Mailer: Mozilla 3.04Gold (X11; I; FreeBSD 5.0-CURRENT i386)
MIME-Version: 1.0
To: Archie Cobbs <archie@whistle.com>
Cc: Warner Losh <imp@village.org>,
	"Andrey A. Chernov" <ache@FreeBSD.org>,
	Archie Cobbs <archie@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if.c if_ethersubr.c if_var.h
References: <200007012328.QAA06644@bubba.whistle.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Archie Cobbs wrote:
> 
> Warner Losh writes:
> > In message <200007011627.JAA05559@bubba.whistle.com> Archie Cobbs writes:
> > : The problem is that the interfaces are not very object oriented
> > : (with respect to type), combined with the dynamically loadable code.
> > : As an example of the former, all ethernet drivers call if_attach()
> > : and ether_attach() when connecting, but only if_detach() when
> > : disconnecting. Perhaps they should all only call ether_attach()
> > : and ether_detach().
> >
> > It should call both.  I thought that pccards all did this, but maybe
> > I'm mistaken.
> 
> ether_detach() doesn't exist yet.. that's another solution, of
> course, to add it and then modify all ethernet drivers to call
> ether_detach() right before calling if_detach().. this would be
> most consistent with the way things are now I guess.

Ethernet drivers should call the ether_* routines
which are in their direct parent class. Those, in turn, should call
the if_* functions if needed.

At least that's the way I see it. 

> 
> -Archie
> 
> ___________________________________________________________________________
> Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com

-- 
      __--_|\  Julian Elischer
     /       \ julian@elischer.org
    (   OZ    ) World tour 2000
     )_.---._/  presently in:  Budapest
            v


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message