From owner-freebsd-geom@FreeBSD.ORG Sun Aug 8 13:07:25 2010 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C65B31065692; Sun, 8 Aug 2010 13:07:25 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello089077043238.chello.pl [89.77.43.238]) by mx1.freebsd.org (Postfix) with ESMTP id 113BB8FC21; Sun, 8 Aug 2010 13:07:24 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id BA9DA45E82; Sun, 8 Aug 2010 15:07:23 +0200 (CEST) Received: from localhost (chello089077043238.chello.pl [89.77.43.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 8A19845D8D; Sun, 8 Aug 2010 15:07:18 +0200 (CEST) Date: Sun, 8 Aug 2010 15:07:09 +0200 From: Pawel Jakub Dawidek To: Marius =?iso-8859-1?Q?N=FCnnerich?= Message-ID: <20100808130709.GD2037@garage.freebsd.pl> References: <20100808103055.GA2037@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wLAMOaPNJ0fu1fTG" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: freebsd-hackers@freebsd.org, freebsd-current@freebsd.org, Ivan Voras , freebsd-geom@freebsd.org Subject: Re: glabel "force sectorsize" patch X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2010 13:07:25 -0000 --wLAMOaPNJ0fu1fTG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 08, 2010 at 02:57:20PM +0200, Marius N=FCnnerich wrote: > On Sun, Aug 8, 2010 at 14:02, Ivan Voras wrote: > > I'd like to hear comments from the wider audience. In respect with your > > comment, I will compromise: as 4k sector drives have become available > > over the counter more than 6 months ago and so far I think this is the > > first effort to give some support for them, I will commit this patch > > before 9.0 code freeze only if no other support gets developed. >=20 > I do not like this at all. Even if it's just for the KISS and POLA > principles. A geom should do one thing and do it right imo. > Why not write a new geom class that does what you want? New GEOM class only for sectorsize conversion that can operate on metadata will be useful, not only to solve this particular problem. Although keep in mind that if at some point disks will be detected and presented as 4kB providers to the GEOM, this class won't be able to find its metadata anymore (as it was stored in the last 512 bytes, not in the last 4 kilobytes). --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --wLAMOaPNJ0fu1fTG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkxeq/0ACgkQForvXbEpPzSslACffbs/r5gFexV0pRgsaN76YDej ONEAoIpXoEgrLqpWXs7Vk4kryYTyvWUu =mN1A -----END PGP SIGNATURE----- --wLAMOaPNJ0fu1fTG--