From owner-svn-src-head@FreeBSD.ORG Mon Jan 20 20:50:26 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4D5F2CD5; Mon, 20 Jan 2014 20:50:26 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 21C6B199D; Mon, 20 Jan 2014 20:50:26 +0000 (UTC) Received: from pippin.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id F1F33B958; Mon, 20 Jan 2014 15:50:24 -0500 (EST) From: John Baldwin To: Rui Paulo Subject: Re: svn commit: r260898 - head/sys/kern Date: Mon, 20 Jan 2014 11:32:29 -0500 Message-ID: <1536225.gsjt6oXMt2@pippin.baldwin.cx> User-Agent: KMail/4.10.5 (FreeBSD/11.0-CURRENT; KDE/4.10.5; amd64; ; ) In-Reply-To: References: <201401200159.s0K1xa5X012123@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 20 Jan 2014 15:50:25 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Neel Natu X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jan 2014 20:50:26 -0000 On Sunday 19 January 2014 18:18:03 Rui Paulo wrote: > On 19 Jan 2014, at 17:59, Neel Natu wrote: > > Author: neel > > Date: Mon Jan 20 01:59:35 2014 > > New Revision: 260898 > > URL: http://svnweb.freebsd.org/changeset/base/260898 > > > > Log: > > Bump up WITNESS_COUNT from 1024 to 1536 so there are sufficient entries > > for > > WITNESS to actually work. > > This value should be automatically tuned... How do you propose to do so? This is the count of locks initialized before witness' own SYSINIT is executed and the array it sizes is allocated statically at compile time. This used to not be a static array, but an intrusive list embedded in locks themselves, but we decided to shave a pointer off of each lock that was only used for that and to use a statically sized table instead. -- John Baldwin