From owner-cvs-src-old@FreeBSD.ORG Thu Dec 16 17:05:57 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 75C741065679 for ; Thu, 16 Dec 2010 17:05:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6341A8FC17 for ; Thu, 16 Dec 2010 17:05:57 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id oBGH5v8g028017 for ; Thu, 16 Dec 2010 17:05:57 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id oBGH5vvk028016 for cvs-src-old@freebsd.org; Thu, 16 Dec 2010 17:05:57 GMT (envelope-from jhb@repoman.freebsd.org) Message-Id: <201012161705.oBGH5vvk028016@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jhb@repoman.freebsd.org using -f From: John Baldwin Date: Thu, 16 Dec 2010 17:05:28 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/acpica acpi_hpet.c src/sys/x86/isa atrtc.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2010 17:05:57 -0000 jhb 2010-12-16 17:05:28 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_hpet.c sys/x86/isa atrtc.c Log: SVN rev 216490 on 2010-12-16 17:05:28Z by jhb Small style fixes: - Avoid side-effect assignments in if statements when possible. - Don't use ! to check for NULL pointers, explicitly check against NULL. - Explicitly check error return values against 0. - Don't use INTR_MPSAFE for interrupt handlers with only filters as it is meaningless. - Remove unneeded function casts. Revision Changes Path 1.36 +12 -14 src/sys/dev/acpica/acpi_hpet.c 1.13 +10 -10 src/sys/x86/isa/atrtc.c