From owner-svn-ports-head@freebsd.org Sat Aug 6 07:38:32 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5E49BB0A8F; Sat, 6 Aug 2016 07:38:32 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B2E081EF6; Sat, 6 Aug 2016 07:38:32 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id C5961BDC71; Sat, 6 Aug 2016 09:38:30 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id A565DBDC66; Sat, 6 Aug 2016 09:38:30 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id 5257966155FD; Sat, 6 Aug 2016 09:38:30 +0200 (CEST) Date: Sat, 06 Aug 2016 09:38:30 +0200 From: Mathieu Arnold To: Alexey Dokuchaev cc: Pawel Pekala , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r419716 - in head/games: . zdoom Message-ID: <3DA12F22975D816013905296@atuin.in.mat.cc> In-Reply-To: <20160806073604.GD53097@FreeBSD.org> References: <201608052308.u75N8bQf092339@repo.freebsd.org> <02F62285C025519217DB3167@atuin.in.mat.cc> <20160806073604.GD53097@FreeBSD.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="==========8A2A682E427F0DD1B403==========" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Aug 2016 07:38:33 -0000 --==========8A2A682E427F0DD1B403========== Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline +--On 6 ao=C3=BBt 2016 07:36:04 +0000 Alexey Dokuchaev wrote: | On Sat, Aug 06, 2016 at 02:01:32AM +0200, Mathieu Arnold wrote: |> +--On 5 ao??t 2016 23:08:37 +0000 Pawel Pekala = wrote: |> | +PLIST_FILES=3D bin/${PORTNAME} \ |> | + %%DATADIR%%/${PORTNAME}.pk3 |>=20 |> This should be: |> PLIST_FILES=3D bin/${PORTNAME} \ |> ${DATADIR}/${PORTNAME}.pk3 |=20 | Why? Now it looks inconsistent: |=20 | % make -V PLIST_FILES | bin/zdoom /usr/local/share/zdoom/zdoom.pk3 |=20 | If your point was to avoid plist substitutions for some reason (if they = do | not work in PLIST_FILES it looks like a bug that should be fixed = instead), | ${DATADIR_REL} still suits better. Substitutions are there for one reason only, to be able to carry variables from the Makefile to the pkg-plist file. DATADIR is just fine, it is the full path to the file, which is supported. --=20 Mathieu Arnold --==========8A2A682E427F0DD1B403========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJXpZP2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I30UP/3ARKELzp9ED96+9Txu/d55r QaQUU7QHpq0GlImKkXuTRGOyyVBcw2IDRQ9JUOsSvy2NEqOBMbdWXCY9SfK3Hj+o H3alyV6EFdF69H8AA90zuWYELhcGA5f2v20E0cvXHBXVQ61w43Qxn0xn2+mq191J 4atrVP4ftEOeNtDHwXrfss7PZz3UqeXox8Vj7FLdYQ0NFWkge2XceZNdOcWHISkZ c1h9b2jOeiYtL0uQISt2k2Z/+Qk66B6qCOZqdLK32U1hb6WhASaREPVBBlFXcRVD TG2VQDqT6HOlCSBrZhvNPQWg1CkzE/gJlIdCnjB+MjD2NJ9nmcrmvKvrqE4LUIPW P8suw7xJ3zlTPbVx7Nxhv62myD9890eTC8ulZwtGs7QSzjz9lKxwPzvocRJYOkHN veXxaVjovW7TRye6BN3CmssPKb4JrCF0X5h/jr8VGJu7ODZyjPNVWNeE9F2uQaxI mfOZ80vA2KgNhAozqxaMQbeWr2aKaiVBNGDLlWXM2R7BSkxbiSviHt9gtaDS6p7L 3XTN8VmDusD2hVaos599/mKNS+rGh6uGS/9E+f3x/Za7TydQ0Hx/BsOYVmEnOLu3 G/oVgOcZrpNpcr0UYhbSDWhr6f1Ut0mrhhfY8dS8V4dENRUPM/yruxHgkKo0HGep nE9QEwAOTQHJ2pqPMqvp =8wOG -----END PGP SIGNATURE----- --==========8A2A682E427F0DD1B403==========--