Date: Sun, 20 May 2012 00:40:59 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@FreeBSD.org, Gleb Kurtsou <gleb@FreeBSD.org>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r235647 - in head: include lib/libc/gen usr.sbin/cpucontrol usr.sbin/lpr/common_source usr.sbin/newsyslog Message-ID: <20120520000910.D1142@besplex.bde.org> In-Reply-To: <20120519133808.GI2358@deviant.kiev.zoral.com.ua> References: <201205191244.q4JCiSmO022413@svn.freebsd.org> <20120519133808.GI2358@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 19 May 2012, Konstantin Belousov wrote: >> Log: >> Hide DIR definition by making it an opaque struct typedef. >> >> Introduce dirfd() libc exported symbol replacing macro with same name, >> preserve _dirfd() macro for internal use. >> >> Replace dirp->dd_fd with dirfd() call. Avoid using dirfd as variable >> name to prevent shadowing global symbol. >> >> Sponsored by: Google Summer Of Code 2011 >> >> Added: >> head/lib/libc/gen/dirfd.c (contents, props changed) >> head/lib/libc/gen/gen-private.h (contents, props changed) > I could agree with attribution of the gen-private.h content to 'regents > of the university' in the copyright, but I very much doubt that this > is right thing to do for dirfd.c. > > I think you should put your name, instead of university, as the copyright > owner. gen-private.h is also missing all history and in particular is missing the history needed to connect it to the regents. gen-private.h also has a gnu-style name. If it had been provided by the regents or their direct contributors, then it would have a BSD-style name (gen_private.h or just genprivate.h, or maybe gen.h or dirfd.h (headers in libc/gen are private by definition; if they were private to libc and not just libc/gen, then they would be in libc/include)). In 4.4BSD-Lite2, there are 22246 files; 1237 of these are named *-*, but most of these are in src/contrib and other contribed files (mainly usr.sbin/amd); there are about 20 files whose name has a hyphen and whose contents has a regents copyright; none of these are in src/lib but 5 are in src/sys. In FreeBSD now, the naming scheme has already rotted to about 55 names with a hyphen in src/lib and 524 in src/sys (more than 1/2 of the latter in contrib/octeon and almost 1/4 in contribed drivers). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120520000910.D1142>