From nobody Tue May 28 16:54:03 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vpdrq6nXgz5Mj8B; Tue, 28 May 2024 16:54:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vpdrq6HBVz4GXg; Tue, 28 May 2024 16:54:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716915243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZWateLlOzK5g8oaBQ8GK+RpPqJPxGIdVLMS2AEXNa3g=; b=CecdFJrzvYi7w1Sh1LqVi0/7JQZ4ve4fVdGIbPjpz5/55sdEaByFYwu/6g+RPK037CdG9e qP8u24un+ezwnfD9S6Z1XLLauy2vvHMSplc1/5enQQrMsk8jRQ61k2j3xekkReaRGl1TyY ugcTiz6nPkdbN9wp8sgHq8748PuTTm1Y50Fr2VENn2uibLxFTRzWJS+9oV9ewqbsyUPWqM fUAwm3kK6nCgGfy+VbKv5eYuqjJCsVIllh14yXd7aJdUTtdk8Dap8dceUW0IopMMjT7y6m 5/BwNcSoOoBKIU8T7BbOf4DzZKnkOYPz+wwG5H1T2kZwYAco+qOugg2HNhPi+Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716915243; a=rsa-sha256; cv=none; b=YtUUR2T2L4XPFZARpaLjxYRy45sUlc8uDi47cwEFYhlQV07eUrTLpr/OShJLOygFS1E+A4 4g0d4AMqL5nk40Uh3LGIkRl83SrT8yjgszJHJ4x22GeEbOEDbgcGSRkAqXiqskhaDhoe/2 n11tHpq3fk3VX04xr5XB81hMzXo1oXkRuoT9oVEhJeD6i2zNFhb4+WtSVH2RJ126/gtpHe AO88+YYTc+SyB3qxZhi8nTLiEi/nhSjyZL21hFvigiTLHKepQWWlJA4Z4woaM66x2hEq7C AjQYu4J3Ow9Hyuzt3nY78RjvUytWh1ebOYy5n5SPRLMoUbOSFFG59pYvhEHByg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716915243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZWateLlOzK5g8oaBQ8GK+RpPqJPxGIdVLMS2AEXNa3g=; b=UlClAsFBKifluVXtmvG5szOG1+20nfFEydlCrjHCdLB+jkzb88p/MsmRFVh2eF/dR/nNn/ Gr9gMAxE1Xo1J3x+6Wn3x4Z6/awNs7DMMkVccX/d867YcFQzOUivDs2o5oLy4UnQFscsay z/g8rxnWZbpZkw9Mw5aJAM4EIVoZe1cVaJ0QEjveDNzDqtIOahkz6FWFN8UnMB9GL5MwOY dI8jiwZFnrLwL77I8WUXbk0A447QZ6zPlOI+m+Ud8pjWoAlJHCXamXR3R4kaxdBDMYiBVL MWKTF6g9HfsPUYVlc/l8xwLhXZGMZ4A8J3qYc07WWwei4snj7GSPs49Jw6vJ5w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Vpdrq5tKmzL91; Tue, 28 May 2024 16:54:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44SGs35V091724; Tue, 28 May 2024 16:54:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44SGs3iM091721; Tue, 28 May 2024 16:54:03 GMT (envelope-from git) Date: Tue, 28 May 2024 16:54:03 GMT Message-Id: <202405281654.44SGs3iM091721@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Bernard Spil Subject: git: 7f4862613c87 - main - security/openssl-quictls: Security update for CVE-2024-4741 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brnrd X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7f4862613c8752bfee5a51a6e75143d033ac6aed Auto-Submitted: auto-generated The branch main has been updated by brnrd: URL: https://cgit.FreeBSD.org/ports/commit/?id=7f4862613c8752bfee5a51a6e75143d033ac6aed commit 7f4862613c8752bfee5a51a6e75143d033ac6aed Author: Bernard Spil AuthorDate: 2024-05-28 16:53:49 +0000 Commit: Bernard Spil CommitDate: 2024-05-28 16:53:49 +0000 security/openssl-quictls: Security update for CVE-2024-4741 Security: 73a697d7-1d0f-11ef-a490-84a93843eb75 MFH: 2024Q2 --- security/openssl-quictls/Makefile | 2 +- security/openssl-quictls/files/patch-CVE-2024-4741 | 69 ++++++++++++++++++++++ 2 files changed, 70 insertions(+), 1 deletion(-) diff --git a/security/openssl-quictls/Makefile b/security/openssl-quictls/Makefile index dcbbe295d024..9afe495b48d4 100644 --- a/security/openssl-quictls/Makefile +++ b/security/openssl-quictls/Makefile @@ -1,7 +1,7 @@ PORTNAME= openssl DISTVERSIONPREFIX= ${PORTNAME}- DISTVERSION= 3.0.13 -PORTREVISION= 4 +PORTREVISION= 5 DISTVERSIONSUFFIX= -quic1 CATEGORIES= security devel PKGNAMESUFFIX= -${GH_ACCOUNT} diff --git a/security/openssl-quictls/files/patch-CVE-2024-4741 b/security/openssl-quictls/files/patch-CVE-2024-4741 new file mode 100644 index 000000000000..f4f5ca1069a1 --- /dev/null +++ b/security/openssl-quictls/files/patch-CVE-2024-4741 @@ -0,0 +1,69 @@ +From b3f0eb0a295f58f16ba43ba99dad70d4ee5c437d Mon Sep 17 00:00:00 2001 +From: Watson Ladd +Date: Wed, 24 Apr 2024 11:26:56 +0100 +Subject: [PATCH] Only free the read buffers if we're not using them + +If we're part way through processing a record, or the application has +not released all the records then we should not free our buffer because +they are still needed. + +CVE-2024-4741 + +Reviewed-by: Tomas Mraz +Reviewed-by: Neil Horman +Reviewed-by: Matt Caswell +(Merged from https://github.com/openssl/openssl/pull/24395) + +(cherry picked from commit 704f725b96aa373ee45ecfb23f6abfe8be8d9177) +--- + ssl/record/rec_layer_s3.c | 9 +++++++++ + ssl/record/record.h | 1 + + ssl/ssl_lib.c | 3 +++ + 3 files changed, 13 insertions(+) + +diff --git a/ssl/record/rec_layer_s3.c b/ssl/record/rec_layer_s3.c +index 4bcffcc41e364..1569997bea2d3 100644 +--- ssl/record/rec_layer_s3.c.orig ++++ ssl/record/rec_layer_s3.c +@@ -81,6 +81,15 @@ int RECORD_LAYER_read_pending(const RECORD_LAYER *rl) + return SSL3_BUFFER_get_left(&rl->rbuf) != 0; + } + ++int RECORD_LAYER_data_present(const RECORD_LAYER *rl) ++{ ++ if (rl->rstate == SSL_ST_READ_BODY) ++ return 1; ++ if (RECORD_LAYER_processed_read_pending(rl)) ++ return 1; ++ return 0; ++} ++ + /* Checks if we have decrypted unread record data pending */ + int RECORD_LAYER_processed_read_pending(const RECORD_LAYER *rl) + { +diff --git a/ssl/record/record.h b/ssl/record/record.h +index 234656bf93942..b60f71c8cb23b 100644 +--- ssl/record/record.h.orig ++++ ssl/record/record.h +@@ -205,6 +205,7 @@ void RECORD_LAYER_release(RECORD_LAYER *rl); + int RECORD_LAYER_read_pending(const RECORD_LAYER *rl); + int RECORD_LAYER_processed_read_pending(const RECORD_LAYER *rl); + int RECORD_LAYER_write_pending(const RECORD_LAYER *rl); ++int RECORD_LAYER_data_present(const RECORD_LAYER *rl); + void RECORD_LAYER_reset_read_sequence(RECORD_LAYER *rl); + void RECORD_LAYER_reset_write_sequence(RECORD_LAYER *rl); + int RECORD_LAYER_is_sslv2_record(RECORD_LAYER *rl); +diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c +index eed649c6fdee9..d14c55ae557bc 100644 +--- ssl/ssl_lib.c.orig ++++ ssl/ssl_lib.c +@@ -5492,6 +5492,9 @@ int SSL_free_buffers(SSL *ssl) + if (RECORD_LAYER_read_pending(rl) || RECORD_LAYER_write_pending(rl)) + return 0; + ++ if (RECORD_LAYER_data_present(rl)) ++ return 0; ++ + RECORD_LAYER_release(rl); + return 1; + }