From owner-p4-projects@FreeBSD.ORG  Mon Apr 25 20:07:13 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id CA04616A4D0; Mon, 25 Apr 2005 20:07:12 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8A21816A4CE
	for <perforce@freebsd.org>; Mon, 25 Apr 2005 20:07:12 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6D01F43D58
	for <perforce@freebsd.org>; Mon, 25 Apr 2005 20:07:12 +0000 (GMT)
	(envelope-from areisse@nailabs.com)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j3PK7CIU028687
	for <perforce@freebsd.org>; Mon, 25 Apr 2005 20:07:12 GMT
	(envelope-from areisse@nailabs.com)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j3PK7CVN028684
	for perforce@freebsd.org; Mon, 25 Apr 2005 20:07:12 GMT
	(envelope-from areisse@nailabs.com)
Date: Mon, 25 Apr 2005 20:07:12 GMT
Message-Id: <200504252007.j3PK7CVN028684@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	areisse@nailabs.com using -f
From: Andrew Reisse <areisse@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 75966 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Apr 2005 20:07:13 -0000

http://perforce.freebsd.org/chv.cgi?CH=75966

Change 75966 by areisse@areisse_ibook on 2005/04/25 20:06:16

	A routine with the checkaccess flag needs a trailer.
	The return code isn't always in the out structure.

Affected files ...

.. //depot/projects/trustedbsd/sedarwin7/src/darwin/bootstrap_cmds/migcom.tproj/routine.c#4 edit
.. //depot/projects/trustedbsd/sedarwin7/src/darwin/bootstrap_cmds/migcom.tproj/server.c#4 edit

Differences ...

==== //depot/projects/trustedbsd/sedarwin7/src/darwin/bootstrap_cmds/migcom.tproj/routine.c#4 (text+ko) ====

@@ -1819,7 +1819,8 @@
     if (mig_errors > 0) 
         fatal("%d errors found. Abort.\n", mig_errors);
 
-    rt->rtServerImpl  = rtCountMask(rt->rtArgs, akbServerImplicit);
+    rt->rtServerImpl  = rtCountMask(rt->rtArgs, akbServerImplicit)
+	+ rt->rtCheckAccess;
     rt->rtUserImpl = rtCountMask(rt->rtArgs, akbUserImplicit);
     /*
      * ASSUMPTION:

==== //depot/projects/trustedbsd/sedarwin7/src/darwin/bootstrap_cmds/migcom.tproj/server.c#4 (text+ko) ====

@@ -1506,7 +1506,9 @@
     fprintf(file, ");\n");
 
     if (rt->rtCheckAccess)
-	fprintf(file, "\t} else\n\t  OutP->%s = KERN_NO_ACCESS;\n", arg->argMsgField);
+	fprintf(file, "\t} else\n\t  %s%s = KERN_NO_ACCESS;\n",
+		akCheck(arg->argKind, akbVarNeeded) ? "" : "OutP->",
+		arg->argMsgField);
 }
 
 static void