From owner-svn-src-all@freebsd.org Wed Apr 19 18:47:54 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55047D45AEC; Wed, 19 Apr 2017 18:47:54 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1E151D15; Wed, 19 Apr 2017 18:47:54 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x241.google.com with SMTP id d203so6162468iof.2; Wed, 19 Apr 2017 11:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=izGkNgoc1MPDuYZdTAAQHuwg15mfnFiF97spAEzmrkU=; b=SKoAuMnJ0OQejYKsH/s1pMwfIG8SSpCtrn7sifTwnX8Y3sduCLdAiCcqPnsBVlFr4H kQe4Sa45jIrCvsE3mPXmfmE/utqaDIacSwXxxEdvh6527pjoBkss0uiZwH4Fgt0OJiwz Sd9SvxknC0bdY9ZsuZ/a5TIcLq2lUB/5YCSgtjVviiPMNYwmX8iBIP+lWmVnVBSC4s5T xvoI6usBBeBl3jOO/sNSN0pfb5i4t71k7TaWkVvJeCv1vCSgGOIoPTiYLpoQ4Y+1N4vN o7XMB0twHp7ABdx3fYsoGIu/pVYR1o/xERaWL2iKwmzsH2PmGDhfhhVoY7Phxq3zYtmN QCmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=izGkNgoc1MPDuYZdTAAQHuwg15mfnFiF97spAEzmrkU=; b=A9tX1S94n0iuaKVuvvXHkUOHPM1siNowa6XDYCjTjX+gjyTDmtL2tfz0+oH0bzL/zw vu+aVk5u1qLid+MQUOQxLiYMhesOtrdNqTsIGdVnfYUdUwTCPvcPreoIkWamG970DWwX vvU2kcxvINdvqZ7TAJaCN3WXICwRgOWHl2sSdrD8Kx/EViy+kY22KbfxuI/X4Kbz8nZa mynkr0QpLwhhsPxmHIwkRVgyKiKjHyLoB5qHkPBmUj+5FzekmZi5aUl37LCeBjrhlAdg 7xTkeLFrcB0agmDTpyU727EhLYS+l5Km5pky6PvERDg7/olJpVOC8NV2h7WN2mX4HLT/ ybvg== X-Gm-Message-State: AN3rC/4SyFtTordHpFfydmLqhBhyHJf/WFumJEGMvLK/OJCnn+VJZrwZ VVtzLej9jLm52yp36ZHwUxKWDY546XtU X-Received: by 10.107.191.2 with SMTP id p2mr5632122iof.172.1492627673240; Wed, 19 Apr 2017 11:47:53 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.30.136 with HTTP; Wed, 19 Apr 2017 11:47:31 -0700 (PDT) In-Reply-To: <201704191624.v3JGOImX031395@pdx.rh.CN85.dnsmgr.net> References: <201704191533.v3JFXOHk065533@repo.freebsd.org> <201704191624.v3JGOImX031395@pdx.rh.CN85.dnsmgr.net> From: Ed Maste Date: Wed, 19 Apr 2017 14:47:31 -0400 X-Google-Sender-Auth: tzfvZruAdrCWvbOPKIBwIwkh79E Message-ID: Subject: Re: svn commit: r317145 - in stable/11/sys: boot/mips/uboot conf To: rgrimes@freebsd.org Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 18:47:54 -0000 On 19 April 2017 at 12:24, Rodney W. Grimes wrote: >> >> The linker script CONSTRUCTORS keyword is only meaningful "when linking >> object file formats which do not support arbitrary sections, such as >> ECOFF and XCOFF"[1] and is ignored for other object file formats. >> >> LLVM's lld does not yet accept (and ignore) CONSTRUCTORS, so just remove >> CONSTRUCTORS from the linker script as it has no effect. >> >> [1] https://sourceware.org/binutils/docs/ld/Output-Section-Keywords.html > > ^^^^^^^^^^^^ links to external data is probably not a good idea in > commit messages as it tends to disappear in time. I understand your point, but think it should be phrased differently: commit messages should stand alone. Some projects use a commit message style that consists of little more than "Fixes bug #1723" or "rdar://90210", and I agree that is insufficient. In the quoted commit message above the relevant content from the binutils documentation is quoted inline, and the URL acts as a reference for the citation. I'd argue that a citation without the URL is less useful today, and not really any worse in the case that sourceware.org disappears, given the existence of the Internet Archive and search engines that could locate the content based on the quoted content and/or portions of the URL.