Date: Thu, 22 Sep 2005 14:26:36 +0200 From: Simon Barner <barner@FreeBSD.org> To: Thierry Thomas <thierry@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org, portmgr@FreeBSD.org Subject: Re: ports/85801: [NEW PORT] math/geogebra-i18n: A dynamic software that joins geometry, algebra and calculus Message-ID: <20050922122636.GR25698@zi025.glhnet.mhn.de> In-Reply-To: <200509212039.j8LKdKpC071588@freefall.freebsd.org> References: <200509212039.j8LKdKpC071588@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--rPgHZmYkQ+bUEpVC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thierry Thomas wrote: > Synopsis: [NEW PORT] math/geogebra-i18n: A dynamic software that joins ge= ometry, algebra and calculus >=20 > State-Changed-From-To: open->feedback > State-Changed-By: thierry > State-Changed-When: Wed Sep 21 20:33:18 GMT 2005 > State-Changed-Why:=20 >=20 > This port is fine, but I would just make a minor suggestion: since > DISTNAME is not versioned, it would be easier to maintain if we include > PORTVERSION in DIST_SUBDIR. Could you please review the following patch? >=20 > --- geogebra-i18n.diff begins here --- > diff -urN math/geogebra-i18n.orig/Makefile math/geogebra-i18n/Makefile > --- math/geogebra-i18n.orig/Makefile Wed Sep 21 22:22:06 2005 > +++ math/geogebra-i18n/Makefile Wed Sep 21 22:25:23 2005 > @@ -12,7 +12,7 @@ > MASTER_SITES=3D http://www.geogebra.at/download/InstData/Java/ > DISTNAME=3D geogebra_setup > EXTRACT_SUFX=3D .jar > -DIST_SUBDIR=3D ${PORTNAME} > +DIST_SUBDIR=3D ${PORTNAME}-${PORTVERSION} What a nice idea! What about adding a suggestion to the Porters' Handbook? I've attached my suggestion (portmgr is Cc'ed), feel free to perform some grammar surgery or drop it in case you don't like it ;-) Best regards, Simon --rPgHZmYkQ+bUEpVC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDMqL8Ckn+/eutqCoRAk75AKDQViq4i7j9MpCQBcSNbihepmF4AQCfcgcv BqCubhLxYf1NBnaj07aM/WI= =P1m5 -----END PGP SIGNATURE----- --rPgHZmYkQ+bUEpVC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050922122636.GR25698>