From owner-freebsd-bluetooth@FreeBSD.ORG Mon Oct 5 17:25:25 2009 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C82641065696 for ; Mon, 5 Oct 2009 17:25:25 +0000 (UTC) (envelope-from plunky@rya-online.net) Received: from smtp6.freeserve.com (smtp5.freeserve.com [193.252.22.151]) by mx1.freebsd.org (Postfix) with ESMTP id 84D9C8FC1A for ; Mon, 5 Oct 2009 17:25:25 +0000 (UTC) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3537.me.freeserve.com (SMTP Server) with ESMTP id B57EB1C00088; Mon, 5 Oct 2009 19:25:23 +0200 (CEST) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3537.me.freeserve.com (SMTP Server) with ESMTP id A80F81C00089; Mon, 5 Oct 2009 19:25:23 +0200 (CEST) Received: from rya-online.net (unknown [89.194.138.132]) by mwinf3537.me.freeserve.com (SMTP Server) with SMTP id C7AAA1C00088; Mon, 5 Oct 2009 19:25:22 +0200 (CEST) X-ME-UUID: 20091005172522817.C7AAA1C00088@mwinf3537.me.freeserve.com Received: (nullmailer pid 629 invoked by uid 1000); Mon, 05 Oct 2009 17:26:37 -0000 Date: Mon, 5 Oct 2009 18:26:37 +0100 (BST) To: Masoom Shaikh In-Reply-To: References: User-Agent: Alpine 2.00 (NEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Message-Id: <1254763597.419838.805.nullmailer@galant.ukfsn.org> From: Iain Hibbert Cc: freebsd-bluetooth@freebsd.org Subject: Re: bluetooth.h, c++ include error X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2009 17:25:25 -0000 On Mon, 5 Oct 2009, Masoom Shaikh wrote: > what i am requesting is just variable name change ;-) my tree is at > revision 197571, thus the patch i am presenting is also generated > against it reject this if you want patch against latest revision > > renamed second argument of bt_devfilter() from 'new' to 'dfnew'. df for > device filter to maintain uniformity renamed third argument from 'old' > to 'dfold'. style(9) mentions that for kernel include files exposed to userland (technically, this is always in userland but perhaps the same rules apply) the prototype tag arguments should be made safe, eg starting with a _ perhaps for much this reason.. so, my suggestion would be to use _new and _old etc.. iain (or, just don't use them, they are not especially required :)