From owner-freebsd-ports@freebsd.org Fri Jan 5 08:24:11 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56FDBEBC933 for ; Fri, 5 Jan 2018 08:24:11 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from fmailer.gwdg.de (fmailer.gwdg.de [134.76.11.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0FFB27D6E2; Fri, 5 Jan 2018 08:24:10 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from [134.76.11.222] (helo=email.gwdg.de) by mailer.gwdg.de with esmtp (Exim 4.80) (envelope-from ) id 1eXNIO-0004w3-AT; Fri, 05 Jan 2018 09:24:08 +0100 Received: from UM-EXCHT-A01.um.gwdg.de (134.76.9.210) by um-excht-a02.um.gwdg.de (134.76.9.211) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 5 Jan 2018 09:24:08 +0100 Received: from krabat.raven.hur (91.8.148.12) by email.gwdg.de (134.76.9.210) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 5 Jan 2018 09:24:07 +0100 Subject: Re: FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?) To: L.Bartoletti CC: Mathieu Arnold , References: <46cbd287-186f-9b92-f2a7-d6884c681040@gwdg.de> <37d007c1-0315-5b23-7357-5dc3fcb836fc@gwdg.de> <92d09009-64b3-695a-2282-5acb6ab169f0@tuxfamily.org> <778b4f63-48c7-c717-6c9b-f3ca35c5232c@FreeBSD.org> <0e444e02-fc35-cfa8-ec36-5d8bbb420124@tuxfamily.org> From: Rainer Hurling Message-ID: Date: Fri, 5 Jan 2018 09:24:06 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <0e444e02-fc35-cfa8-ec36-5d8bbb420124@tuxfamily.org> Content-Type: text/plain; charset="utf-8" Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Spam-Level: - X-Virus-Scanned: (clean) by clamav X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 08:24:11 -0000 Hi Loïc, Am 04.01.2018 um 18:37 schrieb L.Bartoletti: > Hi Mathieu, > > Thank you for your review and tips. > > I have just submitted the patch. > > Rainer, QGis 2 may be able to use Qwt6 instead of Qwt5? I just tried to use Qwt6 with QGIS2 and it seems to work. A few small tests showed no regressions, so far. If this is true, I could change my port to use qwt6@qt4, once flavors for QWT hit the ports tree. Thanks to both, Loïc and Mathieu, for the work on this. Best wishes, Rainer > > Regards. > > Loïc > > On 21.12.2017 17:10, Mathieu Arnold wrote: >> Le 19/12/2017 à 20:48, L.Bartoletti a écrit : >>> Hi, >>> >>> Here's my WIP >>> >>> https://gitlab.com/lbartoletti/freebsd_ports/tree/master/qwt6 >> As long as you are defining a default FLAVOR value, do it right: >> >> FLAVOR?= ${FLAVORS:[1]} >> >> There are a few stuffs that could be simplified, this works for both >> flavors:| >> >> | >> >> |PLIST=    ${PKGDIR}/pkg-plist.${FLAVOR} PLIST_SUB+= >> QT_MKSPECDIR=lib/${FLAVOR}/mkspecs DOCSDIR= >> ${PREFIX}/share/doc/qwt6-${FLAVOR} And this: ||@${REINPLACE_CMD} -e >> 's/__QT_VERSION__/${FLAVOR:S/qt//}/g' >> ${WRKSRC}/qwtconfig.pri| >> || >> >> >> >> You are missing: >> >> qt4_CONFLICTS_INSTALL= qwt6-qt5 >> qt5_CONFLICTS_INSTALL= qwt6-qt4 >> >> >> >