From owner-svn-src-all@FreeBSD.ORG Fri Feb 13 18:29:02 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5E2B071D; Fri, 13 Feb 2015 18:29:02 +0000 (UTC) Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46EC8810; Fri, 13 Feb 2015 18:29:01 +0000 (UTC) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPSA id A5D37D08EF; Fri, 13 Feb 2015 10:29:01 -0800 (PST) Date: Fri, 13 Feb 2015 10:29:01 -0800 From: hiren panchasara To: peter@holm.cc, Randall Stewart Subject: Re: svn commit: r278623 - head/sys/kern Message-ID: <20150213182901.GC19044@strugglingcoder.info> References: <201502121331.t1CDV9jR086269@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GZVR6ND4mMseVXL/" Content-Disposition: inline In-Reply-To: <201502121331.t1CDV9jR086269@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 18:29:02 -0000 --GZVR6ND4mMseVXL/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 02/12/15 at 01:31P, Randall Stewart wrote: > Author: rrs > Date: Thu Feb 12 13:31:08 2015 > New Revision: 278623 > URL: https://svnweb.freebsd.org/changeset/base/278623 >=20 > Log: > This fixes a bug I in-advertantly inserted when I updated the callout > code in my last commit. The cc_exec_next is used to track the next > when a direct call is being made from callout. It is *never* used > in the in-direct method. When macro-izing I made it so that it > would separate out direct/vs/non-direct. This is incorrect and can > cause panics as Peter Holm has found for me (Thanks so much Peter for > all your help in this). What this change does is restore that behavior > but also get rid of the cc_next from the array and instead make it > be part of the base callout structure. This way no one else will get > confused since we will never use it for non-direct. > =20 > Reviewed by: Peter Holm and more importantly tested by him ;-) > MFC after: 3 days. > Sponsored by: Netflix Inc. Can I get more info/backtraces for the panic, please? Cheers, Hiren --GZVR6ND4mMseVXL/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJU3kJsXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/l0h4H/1rAFBQoF4rXpfI2JpMlmeA2 bYWKWzH6bATUhvAGKIVf/8kq7qqlXyjPDjm/uEd9qT4IOTZzuCKYZXqmFONa/IPb dql5CBS3bKwyqlQBUywtylKIkXDWKFqHaKO2twMUrjLQ9V9AD6LqbmbBVyuLldNe yNr16DKjfvfY7xEbduRZY1kGq+hbzFFMdIdGZadWiY1CmDFrOuAEKZUwioGigjGt UxJ4gfeEnvGBdQIQ0cdKTt4IybGg3mCzSKyEuPzZ5gHPdSnhSfYWn9rQQKaNGwFy 2gtsZFydLUrfddq8alm2wjVz5Ooj7sc12PP9/f3JaiWzunDHzAZylirGXB4bjBU= =9MGv -----END PGP SIGNATURE----- --GZVR6ND4mMseVXL/--