From owner-svn-ports-all@freebsd.org Sat Aug 20 18:14:19 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34537BC04FF; Sat, 20 Aug 2016 18:14:19 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 298091C35; Sat, 20 Aug 2016 18:14:19 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 285F915C9; Sat, 20 Aug 2016 18:14:19 +0000 (UTC) Date: Sat, 20 Aug 2016 18:14:19 +0000 From: Alexey Dokuchaev To: Thomas Zander Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420501 - head/multimedia/mencoder Message-ID: <20160820181419.GA5929@FreeBSD.org> References: <201608200604.u7K64uNP003537@repo.freebsd.org> <5999F0F82B0381BE2DDD7374@atuin.in.mat.cc> <20160820180622.GC24882@marvin2011.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160820180622.GC24882@marvin2011.fritz.box> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Aug 2016 18:14:19 -0000 On Sat, Aug 20, 2016 at 08:06:22PM +0200, Thomas Zander wrote: > On Sat, Aug 20, 2016 at 09:03:26AM +0200, Mathieu Arnold wrote: > > | Log: > > | Fix UTF-8 subtitle rendering: Make FONTCONFIG a default OPTION > > > > Mmmm, if it does not work correctly without it, it should not be > > optional. > > Valid point, certainly. OTOH there are users who want to run a > minimalistic installation and do not care about subtitles at all, or > don't use UTF charsets. I would prefer not to introduce a must-have > dependency for everyone. The default and the package should of course > support it, hence the new default OPTION. +1. AFAIR, fontconfig is required only for non-Latin (e.g. Russian, Chinese, etc.) subtitles. Just having it on by default is sufficient. ./danfe