From nobody Mon Mar 9 09:12:16 2026 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fTrrG3WKGz6VS0P; Mon, 09 Mar 2026 09:12:30 +0000 (UTC) (envelope-from fuz@fuz.su) Received: from fuz.su (fuz.su [IPv6:2001:41d0:8:e508::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "fuz.su", Issuer "fuz.su" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fTrrF6lHzz3XYm; Mon, 09 Mar 2026 09:12:29 +0000 (UTC) (envelope-from fuz@fuz.su) Authentication-Results: mx1.freebsd.org; none Received: from fuz.su (localhost [127.0.0.1]) by fuz.su (8.18.1/8.18.1) with ESMTPS id 6299CGoP006156 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 9 Mar 2026 10:12:17 +0100 (CET) (envelope-from fuz@fuz.su) Received: (from fuz@localhost) by fuz.su (8.18.1/8.18.1/Submit) id 6299CGle006155; Mon, 9 Mar 2026 10:12:16 +0100 (CET) (envelope-from fuz) Date: Mon, 9 Mar 2026 10:12:16 +0100 From: Robert Clausecker To: Daniel Engberg Cc: Robert Clausecker , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 16eb147bebc3 - main - textproc/comparator: update to 2.14 Message-ID: References: <69adf744.3f9be.78cfb1@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR] X-Rspamd-Queue-Id: 4fTrrF6lHzz3XYm X-Spamd-Bar: ---- Hi Daniel, Am Mon, Mar 09, 2026 at 12:45:33AM +0100 schrieb Daniel Engberg: > On 2026-03-08 23:25, Robert Clausecker wrote: > > The branch main has been updated by fuz: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=16eb147bebc3b183c83c7ea32e1d576b727655a5 > > > > commit 16eb147bebc3b183c83c7ea32e1d576b727655a5 > > Author: Robert Clausecker > > AuthorDate: 2026-02-28 14:52:28 +0000 > > Commit: Robert Clausecker > > CommitDate: 2026-03-08 22:24:48 +0000 > > > > textproc/comparator: update to 2.14 > > This fixes a bug discovered on FreeBSD. > > Changelog: https://gitlab.com/esr/comparator/-/blob/master/NEWS.adoc?ref_type=heads > > --- > > textproc/comparator/Makefile | 6 ++++-- > > textproc/comparator/distinfo | 6 +++--- > > textproc/comparator/files/patch-Makefile | 21 +++++---------------- > > 3 files changed, 12 insertions(+), 21 deletions(-) > > > > .... > > > > diff --git a/textproc/comparator/files/patch-Makefile b/textproc/comparator/files/patch-Makefile > > index 9d1343fd0847..1c6f30d76325 100644 > > --- a/textproc/comparator/files/patch-Makefile > > +++ b/textproc/comparator/files/patch-Makefile > > @@ -1,22 +1,11 @@ > > ---- Makefile.orig 2026-02-10 12:32:33 UTC > > +--- Makefile.orig 2026-02-28 14:41:28 UTC > > +++ Makefile > > -@@ -15,8 +15,8 @@ SOURCES = $(CODE) $(SCRIPTS) $(DOCS) $(EXTRAS) $(TEST) > > +@@ -15,7 +15,7 @@ SOURCES = $(CODE) $(SCRIPTS) $(DOCS) $(EXTRAS) $(TEST) > > EXTRAS = shredtree.py shredcompare.py > > TEST = test > > SOURCES = $(CODE) $(SCRIPTS) $(DOCS) $(EXTRAS) $(TEST) Makefile > > --CFLAGS = -O3 > > --LDFLAGS = > > -+CFLAGS ?= -O3 > > -+LDFLAGS ?= > > +-CFLAGS = -O3 -Wall -Wextra -Werror -fstack-protector-strong -fno-strict-aliasing -DLARGEFILES > > ++CFLAGS += -O3 -Wall -Wextra -fstack-protector-strong -fno-strict-aliasing -DLARGEFILES > > + LDFLAGS = > Hi, > > This now overrides flags set by ports framework which is a violation. > https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags Thank you for the reminder. I will start an audit of my ports and adjust flags in them as necessary as per policy. Yours, Robert Clausecker -- () ascii ribbon campaign - for an encoding-agnostic world /\ - against html email - against proprietary attachments