From owner-svn-ports-all@FreeBSD.ORG  Sat Oct  6 22:40:25 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by hub.freebsd.org (Postfix) with ESMTP id 0E1B6106564A;
	Sat,  6 Oct 2012 22:40:25 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from opti.dougb.net (hub.freebsd.org [69.147.83.54])
	by mx2.freebsd.org (Postfix) with ESMTP id 30F2B14EBD8;
	Sat,  6 Oct 2012 22:40:22 +0000 (UTC)
Message-ID: <5070B355.1000802@FreeBSD.org>
Date: Sat, 06 Oct 2012 15:40:21 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:15.0) Gecko/20121001 Thunderbird/15.0.1
MIME-Version: 1.0
To: Jason Helfman <jgh@FreeBSD.org>
References: <201210060537.q965bUpk005984@svn.freebsd.org>
	<5070A09B.1090404@FreeBSD.org>
	<CAMuy=+iTW7AgjW1QGjS9n9E5hXfwLwq=kKxmBSia2nDKs_-9-g@mail.gmail.com>
	<5070B0F0.6080404@FreeBSD.org>
	<CAMuy=+i15nHdSsyBKo7C4h4jBcGX=ji7ixajhw5W9nXsVHwH5A@mail.gmail.com>
In-Reply-To: <CAMuy=+i15nHdSsyBKo7C4h4jBcGX=ji7ixajhw5W9nXsVHwH5A@mail.gmail.com>
X-Enigmail-Version: 1.4.4
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, nemysis@gmx.ch,
	ports-committers@freebsd.org
Subject: Re: svn commit: r305338 - in head/games/pycadia: . files
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Oct 2012 22:40:25 -0000

On 10/06/2012 15:34, Jason Helfman wrote:
> On Sat, Oct 6, 2012 at 3:30 PM, Doug Barton <dougb@freebsd.org
> <mailto:dougb@freebsd.org>> wrote:
> 
>     On 10/06/2012 15:25, Jason Helfman wrote:
>     > On Sat, Oct 6, 2012 at 2:20 PM, Doug Barton <dougb@freebsd.org
>     <mailto:dougb@freebsd.org>
>     > <mailto:dougb@freebsd.org <mailto:dougb@freebsd.org>>> wrote:
>     >
>     >     On 10/05/2012 22:37, Jason Helfman wrote:
>     >     > Added: head/games/pycadia/files/pycadia.sh.in
>     <http://pycadia.sh.in> <http://pycadia.sh.in>
>     >     >
>     >    
>     ==============================================================================
>     >     > --- /dev/null 00:00:00 1970   (empty, because file is newly
>     added)
>     >     > +++ head/games/pycadia/files/pycadia.sh.in
>     <http://pycadia.sh.in> <http://pycadia.sh.in>
>     >        Sat Oct  6 05:37:29 2012        (r305338)
>     >     > @@ -0,0 +1,6 @@
>     >     > +#!/bin/sh
>     >     > +#
>     >     > +# $FreeBSD$
>     >     > +
>     >     > +cd "%%DATADIR%%"
>     >     > +./pycadia.py
>     >
>     >     Unless there is some reason to cd into that directory, you'd
>     be better
>     >     off with just: %%DATADIR%%/pycadia.py
>     >
>     >     And in any case, shouldn't you be using exec here?
>     >
>     >
>     > I can check with the maintainer, but it does need to be run from the
>     > DATADIR specifically.
> 
>     Ok, that's not a problem. A comment to that effect would probably be
>     useful for future reference.
> 
> 
>     > What would exec provide that isn't currently fulfilled?
> 
>     Eliminating the shell.
> 
> Fair enough. I can discuss with maintainer, as he has many ports that do
> this. I would suggest using %%PYTHON_CMD%% in favor of exec. Do you see
> an issue with that?

Yes, unless %%PYTHON_CMD%% has some magic to eliminate the shell that
I'm not aware of. :)

Try the existing command with and without exec and then look at your ps
output to see my point.

Doug

-- 

    I am only one, but I am one.  I cannot do everything, but I can do
    something.  And I will not let what I cannot do interfere with what
    I can do.
			-- Edward Everett Hale, (1822 - 1909)