Date: Tue, 25 Dec 2012 12:44:22 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Alfred Perlstein <bright@mu.org> Cc: svn-src-stable@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r244663 - stable/9 Message-ID: <20121225104422.GB53644@kib.kiev.ua> In-Reply-To: <50D8B533.8080507@mu.org> References: <201212241422.qBOEMrcF021632@svn.freebsd.org> <CAJ-VmokV-JL_xZ9otRXubKZ8KQKe7GgLuLU3UMij0HUD_KhCNw@mail.gmail.com> <50D8B533.8080507@mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--03sphU6jKm9HdgU1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 24, 2012 at 12:04:03PM -0800, Alfred Perlstein wrote: > On 12/24/12 11:24 AM, Adrian Chadd wrote: > > ... why'd we break the KBI in a stable branch? > > > I am not sure either. >=20 > I think a single VOP for nullfs (while ugly) would have sufficed. No, it doesn't. Even if it would be sufficient, having a switch right after the vtable call is silly. But, ignoring the sillyness, having a single VOP forces a filesystem, needed to override the single bit of behaviour, to override all behaviours hidden from under the common VOP. Besides the incovenience, it breaks the bypass. This is why I did not went this route in the HEAD commit. Making HEAD and stable diverge for the VOP table is unmaintainable. At least one other change which cannot be covered by the VOP table hacking is the struct vfsops new method. Traditionally (my memory goes back to 6.x branch) we did not maintained VFS KBI stability on the branches. --03sphU6jKm9HdgU1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQ2YOFAAoJEJDCuSvBvK1B/ssQAISdLaNUORMPE9M20P0KttJa /myrd3mS4K9RcKqOY3RJ7rrDQwpPie+gS/B/35wYdiREp4oJdCIZRe6qNWm7bzpJ N5Q3uu+WVcOasw4IM9H8CwwNWcZIQJiLh9tm1vMYaoFp8hhUfWp4vvpMelKNR8v0 rztOuF2ql6nj7/RD+cmrODkf4BgAeQq8Sl4zr1HY/Mk0F+O6ik5n3rwTUi+2Uq0f B1j6tW3u8fx8nF1H/kowQ58H6aH+KhcKyvA7oUVYOQK3jLX8tR5KmU10zflOrGn9 yEooI/xJKWFdyZrryiSoF9zcLkjOexlE/4GxgaZuio+CHs0Wn3ZMQAhhCnOiNPCe QE8JOKgPwdOlQAE7q6r8VXNqQylcPZlvbmuhee+rfjx9IXjBi75FAxxuj3PLWyOg RjEHuXGj844rWxGqcsOKwMKMjC2s8KC9J8HcAN8Yz8ogN6sIVflXSra463aEloQP YBnW3j2dkHiYTpuj9v8/DweUzi6C3Bca2Z+wqnedn9UWIRaTccnfcTAtx2EfeLDq mm/c95RL20HzjzLewy8NnlX5rMexJXfs0Y7rKOCd6wigu+HpWDk1IkutczMnwxqg kAFfiJnYnnWqPz+WNiWo7cv0z+t/JJ+LkvTb2D8AZIkwj8Ln0vf6bXoDAaI/RwRc 5jilHzVtYYYz/D37xD4u =/Axn -----END PGP SIGNATURE----- --03sphU6jKm9HdgU1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121225104422.GB53644>