Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Sep 2015 16:46:41 +0000 (UTC)
From:      Luiz Otavio O Souza <loos@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r287716 - head/sys/dev/dwc
Message-ID:  <201509121646.t8CGkfD1038958@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: loos
Date: Sat Sep 12 16:46:41 2015
New Revision: 287716
URL: https://svnweb.freebsd.org/changeset/base/287716

Log:
  Do not call mii_mediachg() from NIC interrupt handler.
  
  This fixes the link instability on banana pi (A20).
  
  Suggested by:	yongari

Modified:
  head/sys/dev/dwc/if_dwc.c

Modified: head/sys/dev/dwc/if_dwc.c
==============================================================================
--- head/sys/dev/dwc/if_dwc.c	Sat Sep 12 16:30:01 2015	(r287715)
+++ head/sys/dev/dwc/if_dwc.c	Sat Sep 12 16:46:41 2015	(r287716)
@@ -821,10 +821,8 @@ dwc_intr(void *arg)
 	DWC_LOCK(sc);
 
 	reg = READ4(sc, INTERRUPT_STATUS);
-	if (reg) {
-		mii_mediachg(sc->mii_softc);
+	if (reg)
 		READ4(sc, SGMII_RGMII_SMII_CTRL_STATUS);
-	}
 
 	reg = READ4(sc, DMA_STATUS);
 	if (reg & DMA_STATUS_NIS) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201509121646.t8CGkfD1038958>