From nobody Thu Sep 21 22:22:07 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rs8yl5jwTz4v4gL for ; Thu, 21 Sep 2023 22:22:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rs8yl4gM5z4GjP for ; Thu, 21 Sep 2023 22:22:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695334927; a=rsa-sha256; cv=none; b=QWqZ2DA2cu4o2Pj4BPqBX/WfGAs5eyrq3hJrMtD7D0OVxPJa3a0NjUbigE7Qel5QboFHCN uarmo1x9aaNBHWIYRsoyJ/Qh9EHUEyQ8v3/OoXdhAut4O1ctspTFCqPPhwB/3MqWkyV/FW nsnjEDIjSGD9Uo/4iAS+TYL+k2nifgzAdMq3yABAA23V6Kls1zNM+NIiI4bzTph/AEpJa/ o/IqiTV+G03XstLbeXA/dpgPF5EGGTMuQPU/AopXfKizf86n8ZnKPjRcm3+yPcf/8E4HAY lCPwP90rcgqodTx1m3ZwFx7ZZ1ZNKLQAQxQIIPhfotL6wYrFfpAOPzTY/+WeeQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695334927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TvhrlxPGw33JNv7qWUUT8xgWcZ1as+Pv8vSxjlhLdzM=; b=luIc5fDF4V3nK59V2J+RoRZvFuTRvFnI5k+oaO3Q+THx5ArSbvibC2y7IqK8mR3e1/CBPB tivfT9b57s5QhJrcBohSzjLClXXZdBanNVtddXvFtzrGr3x5ss8snftzvyT4NR+T6uBRx6 UfmkXb14su27YJvs1+F/+K65HvY//9FTsxBp+TJaAyBFijtgbOw6VG02BsV+jVJot2KLrZ ZAIYxsR+JoNS4kRWA7GtHXByegehVEgAW934PdUAhbeN9QhsFCSG8WZjh2aTAw0LwK+MPc kX2g2aHaR3fw3XvRT30J9MWliRVobpkfs+fYiKyIqsO3dWznVZm9W/Lz+UfAaA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rs8yl3fKGzwgB for ; Thu, 21 Sep 2023 22:22:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38LMM7mZ073009 for ; Thu, 21 Sep 2023 22:22:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38LMM7gM073008 for fs@FreeBSD.org; Thu, 21 Sep 2023 22:22:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 273663] zfsd crashes in the presence of pools with removed TLVs Date: Thu, 21 Sep 2023 22:22:07 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: crash, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: asomers@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable14? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273663 --- Comment #12 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D3676929d3caea131170a48f8e054299d6= 8c81ec5 commit 3676929d3caea131170a48f8e054299d68c81ec5 Author: Alan Somers AuthorDate: 2023-09-12 01:20:39 +0000 Commit: Alan Somers CommitDate: 2023-09-21 22:20:43 +0000 Fix zfsd with the device_removal pool feature. Previously zfsd would crash in the presence of a pool with a top-level-vdev that had previously been removed. The crash happened because the configuration nvlist of such a TLV contains an empty ZPOOL_CONFIG_CHILDREN array, which led to a pop_front from an empty list, which has undefined behavior. The crash only happened in stable/14 and later, probably do to differences in libcxx, but the change should be MFCed anyway. PR: 273663 Reported by: Marek Zarychta Sponsored by: Axcient Reviewed by: mav Differential Revision: https://reviews.freebsd.org/D41818 (cherry picked from commit 0b294a386d34f6584848ed52407687df7ae59861) cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc | 37 +++++++++++++++++++++++++++= ++++ cddl/usr.sbin/zfsd/vdev_iterator.cc | 5 +---- 2 files changed, 38 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=