From owner-cvs-all@FreeBSD.ORG Sat Jun 19 08:59:14 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1888616A4CE; Sat, 19 Jun 2004 08:59:14 +0000 (GMT) Received: from itchy.rabson.org (mailgate.nlsystems.com [80.177.232.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6AB9943D1D; Sat, 19 Jun 2004 08:59:13 +0000 (GMT) (envelope-from dfr@nlsystems.com) Received: from ns0.nlsystems.com (ns0.nlsystems.com [80.177.232.243]) by itchy.rabson.org (8.12.11/8.12.11) with ESMTP id i5J8wnt0012084; Sat, 19 Jun 2004 09:58:49 +0100 (BST) (envelope-from dfr@nlsystems.com) From: Doug Rabson To: David Schultz Date: Sat, 19 Jun 2004 09:58:43 +0100 User-Agent: KMail/1.6.1 References: <200406171523.i5HFNpjs011498@repoman.freebsd.org> <20040618143127.GP9228@elvis.mu.org> <20040619071754.GA73529@VARK.homeunix.com> In-Reply-To: <20040619071754.GA73529@VARK.homeunix.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406190958.43804.dfr@nlsystems.com> X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on itchy.rabson.org X-Virus-Scanned: clamd / ClamAV version 0.71, clamav-milter version 0.71 X-Virus-Status: Clean cc: Max Laier cc: Maxime Henrion cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org cc: Dag-Erling Sm?rgrav Subject: Re: cvs commit: src/contrib/pf/pfctl pfctl_parser.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jun 2004 08:59:14 -0000 On Saturday 19 June 2004 08:17, David Schultz wrote: > On Fri, Jun 18, 2004, Maxime Henrion wrote: > > Dag-Erling Sm?rgrav wrote: > > > Max Laier writes: > > > > Log: > > > > Fix printing of u_int64_t with a cast to unsigned long long. > > > > > > The correct fix is to cast it to uintmax_t and print it with %ju. > > > > Using %llu and a cast to (unsigned long long) is as correct as > > using uintmax_t and %ju because the C99 standard says that "long > > long" is at least 64-bit wide. We generally use {u,}intmax_t in > > FreeBSD because it works in more cases, but in that case we can't > > because OpenBSD doesn't have intmax_t. > > /me wonders how much backpedaling we'll wind up doing on the > uintmax_t casts when someone decides to add uint128_t to gcc > and uintmax_t becomes painfully slow on 32-bit arches. ;-) Gcc already has uint128_t. I use it all the time on PS2 and something like it is used on x86 for SSE...