From owner-p4-projects@FreeBSD.ORG  Sun Jan  6 20:33:21 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A16AE16A41B; Sun,  6 Jan 2008 20:33:21 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 60FB816A418;
	Sun,  6 Jan 2008 20:33:21 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 33D1313C461;
	Sun,  6 Jan 2008 20:33:21 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id m06KVZ3r070598;
	Sun, 6 Jan 2008 13:31:35 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Sun, 06 Jan 2008 13:32:37 -0700 (MST)
Message-Id: <20080106.133237.1784683699.imp@bsdimp.com>
To: jhb@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200801041343.19320.jhb@freebsd.org>
References: <200801041711.m04HBGPG029002@repoman.freebsd.org>
	<20080104.111926.-108774279.imp@bsdimp.com>
	<200801041343.19320.jhb@freebsd.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: gonzo@freebsd.org, perforce@freebsd.org
Subject: Re: PERFORCE change 132497 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jan 2008 20:33:22 -0000

In message: <200801041343.19320.jhb@freebsd.org>
            John Baldwin <jhb@freebsd.org> writes:
: On Friday 04 January 2008 01:19:26 pm M. Warner Losh wrote:
: > In message: <200801041711.m04HBGPG029002@repoman.freebsd.org>
: >             Oleksandr Tymoshenko <gonzo@freebsd.org> writes:
: > : http://perforce.freebsd.org/chv.cgi?CH=132497
: > : 
: > : Change 132497 by gonzo@gonzo_jeeves on 2008/01/04 17:11:07
: > : 
: > : 	o I believe MK_ZFS is more appropriate variable to be checked
: > : 	    in this case.
: > 
: > I thought this was more a case of 'exclude all CDDL code' rather than
: > being tied to ZFS.
: > 
: > Warner
: 
: I dunno, I think gonzo@ might be right.  It's ZFS support for fstat and I 
: think disabling CDDL would disable ZFS as a side effect?

In any event, these changes should be made in head, not here.

Warner

: > : Affected files ...
: > : 
: > : .. //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 edit
: > : 
: > : Differences ...
: > : 
: > : ==== //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 (text+ko) 
: ====
: > : 
: > : @@ -13,7 +13,7 @@
: > :  
: > :  CFLAGS+=-D_KVM_VNODE
: > :  
: > : -.if ${MK_CDDL} != "no"
: > : +.if ${MK_ZFS} != "no"
: > :  CFLAGS+= -DZFS
: > :  OBJS+= zfs/zfs.o
: > :  SUBDIR=	zfs
: > : 
: > 
: 
: 
: 
: -- 
: John Baldwin
: