Date: Thu, 25 Jun 2009 09:18:47 -0400 From: George Neville-Neil <gnn@neville-neil.com> To: Navdeep Parhar <np@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r194918 - head/sys/net Message-ID: <29388187-3617-40D4-ACDA-DECD97F8274F@neville-neil.com> In-Reply-To: <200906242153.n5OLrPEV030916@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Jun 24, 2009, at 17:53 , Navdeep Parhar wrote: > Author: np > Date: Wed Jun 24 21:53:25 2009 > New Revision: 194918 > URL: http://svn.freebsd.org/changeset/base/194918 > > Log: > Add 10Gbase-T to known ethernet media types. > > Approved by: gnn (mentor) > MFC after: 1 week. > > Modified: > head/sys/net/if_media.h > > Modified: head/sys/net/if_media.h > = > = > = > = > = > = > = > = > ====================================================================== > --- head/sys/net/if_media.h Wed Jun 24 21:51:42 2009 (r194917) > +++ head/sys/net/if_media.h Wed Jun 24 21:53:25 2009 (r194918) > @@ -149,6 +149,7 @@ uint64_t ifmedia_baudrate(int); > #define IFM_10G_TWINAX_LONG 23 /* 10GBase Twinax Long copper */ > #define IFM_10G_LRM 24 /* 10GBase-LRM 850nm Multi-mode */ > #define IFM_UNKNOWN 25 /* media types not defined yet */ > +#define IFM_10G_T 26 /* 10GBase-T - RJ45 */ > > > /* note 31 is the max! */ > @@ -358,6 +359,7 @@ struct ifmedia_description { > { IFM_10G_TWINAX, "10Gbase-Twinax" }, \ > { IFM_10G_TWINAX_LONG, "10Gbase-Twinax-Long" }, \ > { IFM_UNKNOWN, "Unknown" }, \ > + { IFM_10G_T, "10Gbase-T" }, \ > { 0, NULL }, \ > } > > @@ -615,6 +617,7 @@ struct ifmedia_baudrate { > { IFM_ETHER | IFM_10G_TWINAX, IF_Gbps(10ULL) }, \ > { IFM_ETHER | IFM_10G_TWINAX_LONG, IF_Gbps(10ULL) }, \ > { IFM_ETHER | IFM_10G_LRM, IF_Gbps(10ULL) }, \ > + { IFM_ETHER | IFM_10G_T, IF_Gbps(10ULL) }, \ > \ > { IFM_TOKEN | IFM_TOK_STP4, IF_Mbps(4) }, \ > { IFM_TOKEN | IFM_TOK_STP16, IF_Mbps(16) }, \ Howdy, John Baldwin pointed out to me that UNKNOWN really should have been pushed up to the end. Can you make a small patch and send it to me? Increase the number and move its string to the end of the array? Best, Georgehome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?29388187-3617-40D4-ACDA-DECD97F8274F>