From owner-freebsd-current  Mon Oct 28 12:46:56 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7139B37B401; Mon, 28 Oct 2002 12:46:55 -0800 (PST)
Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BDECD43E42; Mon, 28 Oct 2002 12:46:54 -0800 (PST)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id g9SKksf33979;
	Mon, 28 Oct 2002 15:46:54 -0500 (EST)
	(envelope-from jroberson@chesapeake.net)
Date: Mon, 28 Oct 2002 15:46:54 -0500 (EST)
From: Jeff Roberson <jroberson@chesapeake.net>
To: John Baldwin <jhb@FreeBSD.org>
Cc: Nate Lawson <nate@root.org>, <current@FreeBSD.org>,
	Joe Marcus Clarke <marcus@marcuscom.com>,
	Terry Lambert <tlambert2@mindspring.com>
Subject: Re: libgtop port and v_tag changes
In-Reply-To: <XFMail.20021028154207.jhb@FreeBSD.org>
Message-ID: <20021028154420.K62100-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Mon, 28 Oct 2002, John Baldwin wrote:

>
> > Terry is right.  It needs to be the same inode number that is reported by
> > stat and getdirents.  It's unfortunate that you can't do a getattr or stat
> > based on the address of the vnode.  I have actually used and relied on this
> > behavior in the past.  Not specifically with gtop though.
>
>         if ((error = VOP_GETATTR(vp, vap, cred, td)) == 0) {
>                 vp->v_cachedfs = vap->va_fsid;
>                 vp->v_cachedid = vap->va_fileid;
>         }
>
> and the only other place it is set:
>
>         vap = &vattr;
>         error = VOP_GETATTR(vp, vap, active_cred, td);
>         if (error)
>                 return (error);
>
>         vp->v_cachedfs = vap->va_fsid;
>         vp->v_cachedid = vap->va_fileid;
>
Oh, right you are.  I was thinking of v_id.  The cachedfs/id have been
added recently.

Cheers,
Jeff


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message