From owner-freebsd-doc Wed May 8 11:13:24 2002 Delivered-To: freebsd-doc@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id 1968137B400 for ; Wed, 8 May 2002 11:13:15 -0700 (PDT) Received: by peitho.fxp.org (Postfix, from userid 1501) id 2F04913669; Wed, 8 May 2002 14:13:09 -0400 (EDT) Date: Wed, 8 May 2002 14:13:09 -0400 From: Chris Faulhaber To: Kris Kennaway Cc: doc@FreeBSD.org Subject: Committer's guide patch for distfile changes (was: Re: cvs commit: ports/java/bsh distinfo) Message-ID: <20020508181308.GA87923@peitho.fxp.org> References: <200205080923.g489N1u60793@freefall.freebsd.org> <20020508104213.A82388@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MGYHOYXEY6WxJCY8" Content-Disposition: inline In-Reply-To: <20020508104213.A82388@xor.obsecurity.org> User-Agent: Mutt/1.3.24i Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 08, 2002 at 10:42:13AM -0700, Kris Kennaway wrote: > On Wed, May 08, 2002 at 02:23:01AM -0700, Ernst de Haan wrote: > > znerd 2002/05/08 02:23:01 PDT > >=20 > > Modified files: > > java/bsh distinfo=20 > > Log: > > Fix bento error (checksum). >=20 > Please summarize the diffs in a followup (forced) commit (like you're > supposed to when you chase checksums). >=20 This seems to come up on a weekly basis. I do not see this addressed in either the Porter's Handbook nor the Committers-Guide so we should probably put it in 'writing'. A similiar note should probably go into the Porter's Handbook; however, since committers are directly affected, I first looked into adding an entry to the Ports-specific FAQ in the Committer's Guide. The following basically states what is required when the checksum for a port's distfile changes without a version change: (warning, untested patch but the point should be obvious) Index: en_US.ISO8859-1/articles/committers-guide/article.sgml =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/doc/en_US.ISO8859-1/articles/committers-guide/article.= sgml,v retrieving revision 1.113 diff -u -r1.113 article.sgml --- en_US.ISO8859-1/articles/committers-guide/article.sgml 6 May 2002 19:13= :38 -0000 1.113 +++ en_US.ISO8859-1/articles/committers-guide/article.sgml 8 May 2002 18:05= :30 -0000 @@ -2247,6 +2247,23 @@ wra(i)th. + + + + What is required procedure for updating checksum for a + port's distfile when the file changes without a version + change? + + + + When the checksum for a port's distfile is updated due + to the author updating the file without changing the port's + revision, the commit message should include a summary of + the relavent diffs between the original and new distfile. + This is done to ensure that the distfile has not been + corrupted or maliciously altered. + + --=20 Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) Comment: FreeBSD: The Power To Serve iD8DBQE82Wq0ObaG4P6BelARArCTAKCgoKohw/EoEq9P7dv5S3WGWTHs4gCfcZri fzCk66zRzeMhScgCOfRUROg= =TVaC -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message