From nobody Fri Oct 31 21:02:05 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cythX6tkmz6FD4c for ; Fri, 31 Oct 2025 21:02:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cythX652gz3LkV for ; Fri, 31 Oct 2025 21:02:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761944524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mt7UBIqPxSOE0dGD0yQvOpK0aEE38FndUKxkrhptSbw=; b=Ep6uXf1CPOW/ieG8BYGfaovqUEw5G+G6Y9VMsvWqpyKvKlju/FUmv+Rsn3vUb3Ltk9XIHR WYu0H/jUISe8wEZ+5dOm4qZTesIfCaj0zYmrugNx/YRNia3kjFnNPDra81e0EAPBrXF6Hq V6fpHOQDcXNQDtg01CvO81fkYGguPCc3hwtkf7HZI7O5pluGVoc5Zs7AHOjho4Scdglrid nRQYXs5YtJeuYm4OoAPs4ANqVD1+1ofPE14KHP0NiKrHZyqsKBWSKhA5Ax1ltZ7wRg9jms ruB6s1SFBbM+nYh0uKP7qIFyIXtA3jBMQYT1a2G5JWC8nvjNds8u3qYHWkg5mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761944524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mt7UBIqPxSOE0dGD0yQvOpK0aEE38FndUKxkrhptSbw=; b=fohduPh4lo23+x8c6Gkp5lFNHxuPkptedwM7/G5EplpdIMHRBc19MV+aUEMI3qtKyyFWrC leTj38PrRHH/SSQKowDkSrNNZ9YqCjfZnNIA/ludD00VWWTVCedxO1RFni4lczqju7Z56s ywBB5jXm+CWckNqld4SY+HYbq2YAlsTLkx/tKEPw9AzPii2cCP/V/E47M3w55NyGivE0oR A8v4/GPeV9uxAdu5gy8XY867/etBuvDAKXAtQUf24hCNQDSQmbn3IltI1P0k8lDxoPrD0f 9IjjdGhvB1WHylVhenin+Qv1Il5SlCLEBaCXxGdJRBBvpsu/GpKtZr3aZ8egKw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761944524; a=rsa-sha256; cv=none; b=p1QltDJZiurmmH41rtHjRifYUKswbw+cX1so3azZV6tbrUlyAIR1KZM1UtugtCbA48KrNU mBbL9M4QiOFQ5Z+C6T2dal33GwIEC6WICfKtPIe2+QqwiTIwDxbBaxz77UY1ES4/2Ss3Dj fX+M59comx2Xam6qqDzozaeS67jwZO+VBJ/itPKLfQxF9ZM0/5KCojck5a8aRy9TqYN/p/ DUIul52jel5c61AO9dZ82l7QuUUEEXL7mJjmaH0q/rkazljKL9aMoN2j4flM1ZQPpYULJF X8VFPW6lMj7GfOftc/CQWvSN10FHvleougc3uwjejSJc++bncH9m7cPwDeDolQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cythX5QZVz1Nn7 for ; Fri, 31 Oct 2025 21:02:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 59VL24rv073671 for ; Fri, 31 Oct 2025 21:02:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 59VL24NV073670 for net@FreeBSD.org; Fri, 31 Oct 2025 21:02:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 283820] ixl multicast filter problems Date: Fri, 31 Oct 2025 21:02:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283820 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db2b2a4788f7925f41d902df6b7f3d19bc= cd6f42f commit b2b2a4788f7925f41d902df6b7f3d19bccd6f42f Author: Bhosale, Yogesh AuthorDate: 2025-10-16 20:02:45 +0000 Commit: Krzysztof Galazka CommitDate: 2025-10-31 20:57:48 +0000 ixl(4): fix multicast promiscuous mode state tracking and filter manage= ment This change reapplies the improvements from commit 89e7335 and adds additional fixes and code optimizations on top of it. The ixl driver supports up to 128 multicast filters in hardware. When t= his limit is exceeded, the driver should enable multicast promiscuous mode. When the count drops below 128, it should disable promiscuous mode and restore individual filters. The driver previously had problems that could corrupt multicast filters list. The main issue was that ixl_dis_multi_promisc() would attempt to disable promiscuous mode without checking if it was actually enabled, potential= ly corrupting existing filters. There was also no state tracking across dr= iver functions, leading to redundant operations. This change adds an IXL_FLAGS_MC_PROMISC flag to track the multicast promiscuous mode state. The flag is set when enabling promiscuous mode = and cleared when disabling it. Early return checks prevent redundant operat= ions when the mode is already in the desired state, avoiding filter corrupti= on and unnecessary hardware calls. Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com PR: 283820 Approved by: kbowling (mentor) Tested by: gowtham.kumar.ks_intel.com Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D52549 (cherry picked from commit 46a8a1f08f88c278e60ebb6daa7a551eb641c67b) sys/dev/ixl/if_ixl.c | 27 +++++++++++- sys/dev/ixl/ixl.h | 1 + sys/dev/ixl/ixl_pf_main.c | 110 +++++++++++++++++++++++++++++++++++++++---= ---- 3 files changed, 120 insertions(+), 18 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=